Repository navigation
refactor(tenant): take the project default from the models package - #23
Merged
Merged
Conversation
models folds pkg/projectscope into pkg/models, so the call moves from projectscope.ResolveProjectId to models.ResolveProjectId. No behaviour change: the same pure function, resolved the same way. The asymmetry this module documents is unchanged and is the reason the default stays in models rather than moving here. Organisation ownership is verified against persisted records and needs the driver this module provides; project ownership is defined and must never be queried, so it belongs where the nine models-only modules can reach it without taking on mongo. Requires the models release that carries models.ResolveProjectId; the go.mod bump lands with it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This refactor moves project resolution logic to the
modelspackage by replacing the directprojectscopedependency withmodels.ResolveProjectId.Centralising this behaviour in
modelsimproves consistency across services and reduces the risk of different implementations drifting over time, especially during the hidden single-project rollout where project ownership must remain deterministic without relying on database lookups.The change also simplifies the tenancy package by removing an unnecessary dependency on an internal subpackage and aligning consumers with the public API exposed by
models. Updating togithub.com/uug-ai/models v1.7.16consolidates the logic in a single canonical location and cleans up unused transitive dependencies in the module graph.