Repository navigation
fix(database): harden insert contracts - #18
Merged
Merged
Conversation
Forward MongoDB insert options and add configurable insert responses, queues, call tracking, reset support, and tests to MockDatabase.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change hardens the database insert contracts by bringing
InsertOneandInsertManyin line with the rest of the database abstraction layer.Previously, insert operations ignored MongoDB-specific options and had limited support in the mock database implementation. That made insert behavior harder to validate in tests and increased the risk of production code diverging from test expectations.
This PR improves reliability in two key ways:
MongoClient.InsertOneandInsertManynow correctly retain and forward supported MongoDB insert options while safely ignoring unrelated wrapper options. This makes insert behavior consistent with other database methods and ensures callers can rely on validation, ordering, comments, and other driver-level configuration being applied correctly.MockDatabasenow fully supports insert expectations, queued responses, option tracking, and call inspection for both single and bulk inserts. This enables more precise tests around insert flows, sequential failures, retries, and option propagation.The added test coverage validates both the option filtering logic and the new mock behaviors, reducing the likelihood of silent regressions in insert handling.