fix: resolver answers

[loks0n]

Summary by CodeRabbit

• Bug Fixes

  • Enhanced wildcard CNAME query resolution with improved response data handling.

• Tests

  • Added comprehensive test coverage for wildcard CNAME query lookup scenarios, verifying authoritative responses with proper CNAME record formatting.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This change fixes array indexing in wildcard DNS resolution handling and adds a test case to verify wildcard CNAME query resolution. The modification wraps synthesizedRecords with array_values() in two wildcard-handling branches within the resolver to ensure proper numeric indexing, while removing associated per-line docblock annotations. A new unit test validates that wildcard CNAME queries resolve correctly with proper authoritative responses and expected CNAME answer records.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Array indexing logic: Verify that array_values() is necessary for the answers field and that it doesn't affect expected DNS resolution behavior
• Docblock removal justification: Confirm that removing the per-line @var annotations doesn't impact code maintainability or IDE autocomplete
• Test coverage: Ensure the new wildcard CNAME test case adequately validates the fix and covers expected edge cases (e.g., response authority, TTL values)

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-resolver-answers

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d1ed3f9 and 7d334bf.

📒 Files selected for processing (2)

• src/DNS/Zone/Resolver.php (2 hunks)
• tests/unit/DNS/Zone/ResolverTest.php (1 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}