Baseline Skeleton Mission Operations (rebased from #31)#138
Draft
jpmedinagl wants to merge 10 commits intomainfrom
Draft
Baseline Skeleton Mission Operations (rebased from #31)#138jpmedinagl wants to merge 10 commits intomainfrom
jpmedinagl wants to merge 10 commits intomainfrom
Conversation
I added idle and init files Signed-off-by: Riaab Zahid <riaab.zahid@gmail.com>
Fixed space at end Signed-off-by: Riaab Zahid <riaab.zahid@gmail.com>
jpmedinagl
requested review from
Kevin-Caldwell,
alexapostolu,
chopikus,
coby1kenobi,
mshinjo and
swarnavaghosh04
as code owners
jpmedinagl
force-pushed
the
mission-ops
branch
from
e0a7b4b to
b496bfd
Compare
I reviewed the comments on the idle.c and idle.h files and corrected them. I also changed the logic of idle.c a bit Signed-off-by: Riaab Zahid <riaab.zahid@gmail.com>
Init commit Signed-off-by: Riaab Zahid <riaab.zahid@gmail.com>
Adding copyright to obc files Signed-off-by: Juan Pablo Medina <jpmedinagl@gmail.com>
Fixed previous formatting issues from PR #31 Removed unneeded empty lines and missing import Signed-off-by: Angela Zheng <angelazheng96@gmail.com>
Replace functions for error prints with Zephyr logging APIs Signed-off-by: Angela Zheng <angelazheng96@gmail.com>
Fixing patch check for CI failure, standard line changes, removing trailing white space... Signed-off-by: Juan Pablo Medina <jpmedinagl@gmail.com>
jpmedinagl
force-pushed
the
mission-ops
branch
from
b496bfd to
0b39a85
Compare
Author
|
Rebased and force-pushed to fix DCO and commit formatting issues. (Line too long, author name not matching Signed-off-by) |
Fixing cppcheck errors, unused functions/variables Signed-off-by: Juan Pablo Medina <jpmedinagl@gmail.com>
mshinjo
reviewed
Oct 18, 2025
Member
mshinjo
left a comment
mshinjo
left a comment
There was a problem hiding this comment.
DNM since commit squashes are expected before we can merge this PR. All authors/contributors need to agree on authorships and DCO handlings.
… into mission-ops
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rebases the changes from the old branch (
riaab/initial-commit) in #31 onto the currentmain.The CI from the original PR (#31) had errors, but the logs have expired.
This PR triggers a fresh CI run so the errors can be inspected again.
Once the CI errors are identified, fixes will be applied as needed.