Skip to content

security: redact session token from viewer access logs #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sunil56224972 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

security: redact session token from viewer access logs #877

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion strix/viewer/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,12 @@ class ViewerHandler(BaseHTTPRequestHandler):
server_version = "StrixViewer/1.0"

def log_message(self, format: str, *args: Any) -> None: # noqa: A002
logger.debug("viewer %s - %s", self.address_string(), format % args)
# Redact the bootstrap token from log lines so it cannot be
# harvested from log files for session hijacking.
msg = format % args
if state.session_token and state.session_token in msg:
msg = msg.replace(state.session_token, "[REDACTED]")
logger.debug("viewer %s - %s", self.address_string(), msg)

def do_GET(self) -> None:
parts = urlsplit(self.path)
Expand Down