Skip to content

Add std::launder to FastPimpl#555

Open
linuxnyasha wants to merge 1 commit intouserver-framework:developfrom
tfwtfwtf:develop
Open

Add std::launder to FastPimpl#555
linuxnyasha wants to merge 1 commit intouserver-framework:developfrom
tfwtfwtf:develop

Conversation

@linuxnyasha
Copy link
Copy Markdown
Contributor

No description provided.

@apolukhin
Copy link
Copy Markdown
Member

apolukhin commented May 3, 2024

This patch breaks code:

error: incomplete type 'experiments3::models::ClientsCacheImpl' where a complete type is required
    return __builtin_launder(__p);
           ^
userver/universal/include/userver/utils/fast_pimpl.hpp:106:38: note: in instantiation of function template specialization 'std::launder<models::ClientsCacheImpl>' requested here
  T* AsHeld() noexcept { return std::launder(reinterpret_cast<T*>(&storage_)); }

Issue in clang: llvm/llvm-project#90949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants