Skip to content

Revert "perf: optimize DNS resolution to reduce request latency" #7723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sid-bruno wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Revert "perf: optimize DNS resolution to reduce request latency" #7723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions packages/bruno-requests/src/network/agent-defaults.ts
View file
Open in desktop

This file was deleted.

5 changes: 2 additions & 3 deletions packages/bruno-requests/src/network/axios-instance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { default as axios, AxiosRequestConfig, AxiosRequestHeaders, AxiosResponse, InternalAxiosRequestConfig } from 'axios';
import http from 'node:http';
import https from 'node:https';
import { defaultAgentOptions } from './agent-defaults';

/**
*
Expand Down Expand Up @@ -30,8 +29,8 @@ type ModifiedAxiosResponse = AxiosResponse & {

const baseRequestConfig: Partial<AxiosRequestConfig> = {
proxy: false,
httpAgent: new http.Agent(defaultAgentOptions),
httpsAgent: new https.Agent(defaultAgentOptions),
httpAgent: new http.Agent({ keepAlive: true }),
httpsAgent: new https.Agent({ keepAlive: true }),
transformRequest: function transformRequest(data: any, headers: AxiosRequestHeaders) {
const contentType = headers.getContentType() || '';
const hasJSONContentType = contentType.includes('json');
Expand Down
60 changes: 0 additions & 60 deletions packages/bruno-requests/src/network/fast-lookup.spec.ts
View file
Open in desktop

This file was deleted.

32 changes: 0 additions & 32 deletions packages/bruno-requests/src/network/fast-lookup.ts
View file
Open in desktop

This file was deleted.

11 changes: 1 addition & 10 deletions packages/bruno-requests/src/utils/agent-cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import tls from 'node:tls';
import type { Agent as HttpAgent } from 'node:http';
import type { Agent as HttpsAgent } from 'node:https';
import { createTimelineAgentClass, createTimelineHttpAgentClass, type TimelineEntry, type AgentOptions, type HttpAgentOptions, type AgentClass, type HttpAgentClass } from './timeline-agent';
import { defaultAgentOptions } from '../network/agent-defaults';

/**
* Agent cache for SSL session reuse.
Expand Down Expand Up @@ -268,16 +267,8 @@ function getOrCreateAgentInternal<TOptions extends HttpAgentOptions>(
}

const AgentClass = timeline ? getTimelineClass(BaseAgentClass) : BaseAgentClass;

// Inject shared agent defaults (DNS lookup, socket pool settings), then
// layer on the caller's options so per-agent overrides still take effect.
const optimizedOptions = {
...defaultAgentOptions,
...options
};

// Convert raw `ca` to a secureContext that adds CAs on top of OpenSSL defaults
const resolvedOptions = applySecureContext(optimizedOptions);
const resolvedOptions = applySecureContext(options);

let agent: HttpAgent | HttpsAgent;
if (timeline) {
Expand Down
Loading