Skip to content

fix: prevent assertions from returning wrong values during large iteration runs #7692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gopu-bruno wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −6
Open

fix: prevent assertions from returning wrong values during large iteration runs #7692

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64244e2
fix: prevent assertions from returning wrong values during large iter…
gopu-bruno Apr 7, 2026
ea2cbe9
fix: handle QuickJS context creation inside try block
gopu-bruno Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions packages/bruno-js/src/sandbox/quickjs/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,9 @@ const { marshallToVm } = require('./utils');
const addCryptoUtilsShimToContext = require('./shims/lib/crypto-utils');
const { wrapScriptInClosure, SANDBOX } = require('../../utils/sandbox');

let QuickJSSyncContext;
let QuickJSModule;
const loader = memoizePromiseFactory(() => newQuickJSWASMModule());
const getContext = (opts) => loader().then((mod) => (QuickJSSyncContext = mod.newContext(opts)));
getContext();
loader().then((mod) => (QuickJSModule = mod));

const toNumber = (value) => {
const num = Number(value);
Expand Down Expand Up @@ -57,9 +56,8 @@ const executeQuickJsVm = ({ script: externalScript, context: externalContext, sc
externalScript = removeQuotes(externalScript);
}

const vm = QuickJSSyncContext;

try {
const vm = QuickJSModule.newContext();
const { bru, req, res, ...variables } = externalContext;

bru && addBruShimToContext(vm, bru);
Expand Down Expand Up @@ -97,7 +95,7 @@ const executeQuickJsVmAsync = async ({ script: externalScript, context: external
externalScript = externalScript?.trim();

try {
const module = await newQuickJSWASMModule();
const module = await loader();
const vm = module.newContext();

// add crypto utilities required by the crypto-js library in bundledCode
Expand Down
Loading