Skip to content

fix(csrf): return 403 on CSRF rejection instead of silent empty 200 #2692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elibosley wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −1
Open

fix(csrf): return 403 on CSRF rejection instead of silent empty 200 #2692

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion emhttp/plugins/dynamix/include/local_prepend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,14 @@

function csrf_terminate($reason) {
exec('logger -t webGUI -- '.escapeshellarg("error: {$_SERVER['REQUEST_URI']} - {$reason} csrf_token"));
exit;
// Reject with an explicit 403 instead of a silent empty 200 so callers can
// tell a CSRF failure apart from a genuine empty result (e.g. a fetch-based
// status read must not render as "service down" when it was simply blocked).
if (!headers_sent()) {
http_response_code(403);
header('Content-Type: application/json');
}
exit(json_encode(['error' => "{$reason} csrf_token"]));
}

putenv('PATH=.:/usr/local/sbin:/usr/sbin:/sbin:/usr/local/bin:/usr/bin:/bin');
Expand Down
Loading