fix: onboarding case model json

[elibosley]

No description provided.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 1df2a278-745a-4bad-9feb-905376b889bb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch codex/onboarding-case-model-json

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Ajit-Mehrotra]

lgtm

[chatgpt-codex-connector]

💡 Codex Review

api/api/src/unraid-api/graph/resolvers/customization/onboarding.service.ts

Line 786 in bf8ef64

if (!this.materializedPartnerMedia.caseModel && !configuredCaseModel) {

Gate case-model asset usage on current materialization

This new guard allows applyCaseModelConfig to proceed whenever branding.caseModel is present, even when no case-model image was materialized for the current activation. In that path the code still prefers fileExists(caseModelSource), so a stale activation/assets/case-model.png left from a previous activation can override the newly provided built-in caseModel value and write the wrong case-model.cfg entry. Please require this.materializedPartnerMedia.caseModel (or clear stale assets before this check) before treating caseModelSource as authoritative.

---

api/web/src/components/Onboarding/constants.ts

Line 1 in bf8ef64

export const ONBOARDING_MODAL_HIDDEN_STORAGE_KEY = 'onboardingModalHidden';

Keep legacy modal-hidden storage key readable

Changing the storage key value from activationCodeModalHidden to onboardingModalHidden drops compatibility with existing session state. After deploy, users who already dismissed onboarding in their current session will have that preference ignored and can see the modal reopen unexpectedly. Consider preserving the old key value or adding a read-migration fallback so existing hidden state is honored.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[github-actions]

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL:

https://preview.dl.unraid.net/unraid-api/tag/PR1896/dynamix.unraid.net.plg

[codecov]

Codecov Report

❌ Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 49.73%. Comparing base (3e43340) to head (42d82ec).

Files with missing lines	Patch %	Lines
...ing/standalone/OnboardingAdminPanel.standalone.vue	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                        Coverage Diff                         @@
##           refactor/onboarding-wizard-gating    #1896   +/-   ##
==================================================================
  Coverage                              49.72%   49.73%           
==================================================================
  Files                                   1021     1021           
  Lines                                  70033    70047   +14     
  Branches                                7388     7392    +4     
==================================================================
+ Hits                                   34827    34840   +13     
- Misses                                 35083    35084    +1     
  Partials                                 123      123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.