fix(chunking): preserve sentence order in NlpSentenceChunking#1910
Closed
kuishou68 wants to merge 1 commit intounclecode:mainfrom
Closed
fix(chunking): preserve sentence order in NlpSentenceChunking#1910kuishou68 wants to merge 1 commit intounclecode:mainfrom
kuishou68 wants to merge 1 commit intounclecode:mainfrom
Conversation
Using list(set(sens)) destroys sentence order and incorrectly deduplicates. Fix: return the sentences list directly.
Collaborator
|
Thanks for your contribution. This is a clean fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1909
Bug
NlpSentenceChunking.chunk()was returninglist(set(sens))which destroys the natural document order of sentences (Python sets are unordered) and incorrectly removes duplicate sentences.Fix
Return
sensdirectly —nltk.sent_tokenize()already returns sentences in document order.