stdexec: update#169
Merged
romintomasetti merged 1 commit intomainfrom Apr 13, 2026
Merged
Conversation
romintomasetti
force-pushed
the
stdexec-update-domain-ouch
branch
from
3b3d693 to
cadd67f
Compare
maartenarnst
approved these changes
Apr 13, 2026
Signed-off-by: romintomasetti <romin.tomasetti@gmail.com>
romintomasetti
force-pushed
the
stdexec-update-domain-ouch
branch
from
cadd67f to
6b9b36e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retrieving:
when_all(a,b)whenaandbhave different completion domains NVIDIA/stdexec#2018__common_domain_tto always check for convertibility todefault_domainNVIDIA/stdexec#2022Going from https://github.com/NVIDIA/stdexec/blame/6b831318ed0a87e464b28c29a01b88695e5d71c6/include/stdexec/__detail/__domain.hpp#L130 to https://github.com/NVIDIA/stdexec/blob/73559e8963dab7a4ece32ede22f6472c9a815032/include/stdexec/__detail/__domain.hpp#L123 removes the
requiresconstraint onindeterminate_domain::transform_sender, so we were getting a compile error. But NVIDIA/stdexec#2022 fixes the common domain so that after the when all with branches on us and thread pool, the domain is the default domain, not the indeterminate one.