-
Notifications
You must be signed in to change notification settings - Fork 42
Align Mesh Gradient, Background Snippets & Color Lab editors with SVG-style sidebar #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
naymurdev
wants to merge
10
commits into
codex/build-developer-first-tool-playground-ui
Choose a base branch
from
codex/fix-mesh-gradient-and-color-lab-page-design
base: codex/build-developer-first-tool-playground-ui
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b96c789
Align tool editors with svg-line-draw style sidebars
naymurdev e8c0dc6
Fix background snippets sidebar JSX parse error
naymurdev 4e9f124
Remove mesh gradient top hero and playground shell sidebar
naymurdev 84b5555
Remove playground shell and sidebar tabs from background and color pages
naymurdev 462c926
Remove top example/hero sections from gradient, background, and color…
naymurdev 39698c6
Adopt svg-line-draw style sidebar layout for mesh gradients and color…
naymurdev 102eea8
Move mesh presets into sidebar and add svg-style sidebar layout to ba…
naymurdev ba5e767
Align background snippets sidebar footer with svg-line-draw pattern
naymurdev 9b32bf3
Remove background snippets top mobile header notice
naymurdev a5e252f
Hide global tools header on mesh, background snippets, and color lab …
naymurdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the Background Snippets editor, this new
{activeSidebarTab === "settings" && <div ...>expression is never closed with a}before the following GradientControls<div>sibling, so the TSX is syntactically invalid and this page will fail to compile/render as soon as the file is parsed.Useful? React with 👍 / 👎.