Fix: Resolve Android cross-compilation failure (Issue #458)#494
Open
dyrpsf wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #458.
The Problem:
When users attempt to compile
h3-pyfor Android using Buildozer /python-for-android, the build fails at runtime withImportError: dlopen failed: ... is for EM_X86_64 (62) instead of EM_AARCH64 (183).Because
p4arelies on standardpip installwithout explicitly passing a CMake toolchain file toscikit-build-core, CMake defaults to building host binaries (x86_64) instead of respecting the target NDK environment.The Solution:
Added a minimal, non-intrusive environment check in the root
CMakeLists.txtjust before theproject()declaration. If the standard$CCenvironment variable containsandroid(which is standard behavior forpython-for-android), it automatically setsCMAKE_SYSTEM_NAMEtoAndroid.This forces CMake into cross-compilation mode, allowing it to correctly link against the ARM64 Android NDK without interfering with standard desktop builds (Linux/Mac/Windows).