Repository navigation
Conversation
Renovate proposed bumping datatables.net-select to v4 (see uPortal-Project#371), which fails to resolve: select v4 requires datatables.net-bs5 [3.1.0,4.0.0), but the core is on 2.3.8 and searchpanes requires [2.0.0,3.0.0) — the ranges do not overlap, so Maven cannot pick a single core version. The six DataTables webjars (core, bs5, searchpanes, select, each in plain + bs5) are a coordinated set whose extensions peer-depend on a compatible core range. No single piece can cross a major boundary while the others stay behind. Cap core + searchpanes at < 3.0.0 and select at < 4.0.0 so Renovate stops proposing partial cross-major bumps; a move to DataTables 3.x+ must bump all six together alongside the consuming uPortal skin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renovate proposed bumping
datatables.net-selectto v4 (see #371). It fails to resolve because the DataTables webjars are a coordinated set with peer-dependency version ranges across the core and extensions:selectv4 wants core (datatables.net-bs5) 3.x, but the core is pinned at 2.3.8 andsearchpanesrequires core 2.x — non-overlapping ranges, so Maven can't pick a single core version.Change
Add two
renovate.jsonrules to keep the six DataTables webjars (core,-bs5,searchpanes(+bs5),select(+bs5)) as a coordinated set:datatables.net,datatables.net-bs5,datatables.net-searchpanes,datatables.net-searchpanes-bs5→< 3.0.0datatables.net-select,datatables.net-select-bs5→< 4.0.0This stops Renovate from proposing partial cross-major bumps of individual DataTables artifacts. A move to DataTables 3.x+ needs to bump all six together, coordinated with the consuming uPortal skin (see also the parked DataTables v3 PR #366).
Notes