Update invalidWordFenceVersions#36
Merged
Merged
Conversation
tangrufus
force-pushed
the
invalidWordFenceVersions
branch
from
11f5cc6 to
f0dbe99
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR expands the set of invalid version strings used in the WordFence version parser tests to cover additional edge cases.
- Added new malformed version patterns (e.g., alphanumeric suffixes, date fragments, revision labels).
- Increased test coverage for uncommon separators and format anomalies.
| "1.1(Beta)", | ||
| "1.3 EN", | ||
| "1.4.9.8.9", | ||
| "1.6.2d", |
There was a problem hiding this comment.
The invalidWordFenceVersions list is growing and currently unsorted; consider grouping entries by major version or sorting them alphabetically for easier future maintenance.
| "4.23.1.1.23.1", | ||
| "4.3-revision-3", | ||
| "44.0 (17-08-2023)", | ||
| "47.0(20-11-2023)", |
There was a problem hiding this comment.
[nitpick] This entry omits the space before the parenthesis, making its formatting inconsistent with similar lines (e.g., "44.0 (17-08-2023)"); normalizing spacing would improve readability.
Suggested change
| "47.0(20-11-2023)", | |
| "47.0 (20-11-2023)", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.