Skip to content

Adds @SideEffecFree annotation to FileInputStream(String) and FileInputStream(File). #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mernst merged 2 commits into from
Jun 4, 2026
Merged

Adds @SideEffecFree annotation to FileInputStream(String) and FileInputStream(File). #280

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98e6a11
Adds @SideEffecFree annotation to FileInputStream(String) and FileInp…
iamsanjaymalakar Apr 22, 2026
763e241
Merge branch 'typetools:master' into 7049-dev
iamsanjaymalakar Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/java.base/share/classes/java/io/FileInputStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
import org.checkerframework.checker.index.qual.LTLengthOf;
import org.checkerframework.checker.index.qual.NonNegative;
import org.checkerframework.checker.mustcall.qual.MustCallAlias;
import org.checkerframework.dataflow.qual.SideEffectFree;
import org.checkerframework.framework.qual.AnnotatedFor;

import java.nio.channels.FileChannel;
Expand Down Expand Up @@ -111,6 +112,7 @@ public class FileInputStream extends InputStream
* to the file.
* @see java.lang.SecurityManager#checkRead(java.lang.String)
*/
@SideEffectFree
public FileInputStream(String name) throws FileNotFoundException {
this(name != null ? new File(name) : null);
}
Comment thread
mernst marked this conversation as resolved.
Expand Down Expand Up @@ -142,6 +144,7 @@ public FileInputStream(String name) throws FileNotFoundException {
* @see java.io.File#getPath()
* @see java.lang.SecurityManager#checkRead(java.lang.String)
*/
@SideEffectFree
public FileInputStream(File file) throws FileNotFoundException {
String name = (file != null ? file.getPath() : null);
@SuppressWarnings("removal")
Expand Down