Skip to content
This repository was archived by the owner on May 23, 2025. It is now read-only.

fix filtering boosts from the home timeline#5116

Merged
connyduck merged 1 commit intodevelopfrom
fix-filtering-boosts
May 10, 2025
Merged

fix filtering boosts from the home timeline#5116
connyduck merged 1 commit intodevelopfrom
fix-filtering-boosts

Conversation

@connyduck
Copy link
Copy Markdown
Collaborator

@connyduck connyduck commented May 9, 2025

Since #5038 the option to filter boosts was ignored and boosts never filtered.

The issue here was that the HomeTimelineData.status holds no reblog information, so timelineData.status?.toStatus(it) will always return a unreblogged status. timelineData.toViewData constructs the correct structure as it considers HomeTimelineData.reblogAccount as well.

@connyduck connyduck requested review from Tak and charlag May 9, 2025 13:25
Copy link
Copy Markdown
Collaborator

@Tak Tak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, nice find

@connyduck connyduck merged commit d7ceadf into develop May 10, 2025
1 check passed
@connyduck connyduck deleted the fix-filtering-boosts branch May 10, 2025 06:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants