Fix custom symbol schematic solver pin IDs and fallback netlabel names#2426
Closed
MustafaMulla29 wants to merge 1 commit into
Closed
Fix custom symbol schematic solver pin IDs and fallback netlabel names#2426MustafaMulla29 wants to merge 1 commit into
MustafaMulla29 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MustafaMulla29
commented
Jun 11, 2026
Contributor
Author
There was a problem hiding this comment.
WIll be looking into trace solver why it creates those other two netlabels instead of traces
MustafaMulla29
requested review from
Sang-it,
ShiboSoftwareDev,
imrishabh18 and
seveibar
and removed request for
imrishabh18 and
seveibar
seveibar
reviewed
Jun 12, 2026
| _getNetLabelText(): string | undefined { | ||
| return `${this.parent?.props.name}_${this.props.name}` | ||
| const componentName = | ||
| this.getParentNormalComponent()?.props.name ?? this.parent?.props.name |
Contributor
There was a problem hiding this comment.
is this.getParentNormalComponent()?.props.name not good enough?
seveibar
reviewed
Jun 12, 2026
| const componentName = | ||
| this.getParentNormalComponent()?.props.name ?? this.parent?.props.name | ||
|
|
||
| return componentName |
Contributor
There was a problem hiding this comment.
when is componentName not defined for a port?
seveibar
reviewed
Jun 12, 2026
seveibar
left a comment
seveibar
left a comment
Contributor
There was a problem hiding this comment.
makes code worse by adding ambiguity and extra LoC unnecessarily for the net label text getter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core was building schematic trace solver pin IDs from
schematic_port.pin_numberonly. Custom symbol ports can be authored withnamebut nopinNumber, so multiple ports on the same custom symbol were sent to the solver as the same ID, e.g.HOST.undefined. That made the solver input ambiguous and caused incorrect routing/fallback behavior.This fixes the solver input generation to use the schematic port’s numeric
pin_numberwhen available, and fall back to the attachedsource_port.namefor named custom symbol ports. The repro now asserts custom symbol connections are emitted asHOST.pin1,HOST.pin2, etc.Also fixed fallback netlabel text generation in Port.ts: ports nested inside
<symbol>were using the immediate parent symbol name, producing labels likeundefined_pin3. Netlabel text now uses the owning normal component name, so custom symbol labels resolve correctly, e.g.HOST_pin3.