Make soko prize replacement logic a bit simpler and more robust#14
Open
RojjaCebolla wants to merge 2 commits into
Open
Make soko prize replacement logic a bit simpler and more robust#14RojjaCebolla wants to merge 2 commits into
RojjaCebolla wants to merge 2 commits into
Conversation
The cases for substitute prizes were complicated and asymmetrical. Oilskin sacks aren't terribly important if you have a BoH.
A player may unknowingly be wearing an amulet of change simply because it's an uncursed amulet; that early in the game, it's not a clear signal that the player doesn't want polycontrol. If they do want polycontrol, they probably don't need an amulet of flying, as flight can be achieved more affordably by polymorphing. Putting a non-ring in the bag of rings is going to feel random to unspoiled players, buggy to lightly-spoiled players, and leak a very arcane piece of information to a source-diver who hasn't identified the ring(s) in their possession. Instead, if the player doesn't need the coveted ring of foo_control, give them the counterpart, a ring of foo. If they don't need that ring either, give a random ring from a range that is unlikely to result in duplicate rings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.