-
-
Notifications
You must be signed in to change notification settings - Fork 830
Add structured output support to ComputerAgent #1276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
r33drichards
wants to merge
1
commit into
main
Choose a base branch
from
claude/add-structured-outputs-Yckd3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: trycua/cua
Length of output: 88
🏁 Script executed:
Repository: trycua/cua
Length of output: 1433
🏁 Script executed:
Repository: trycua/cua
Length of output: 329
🏁 Script executed:
Repository: trycua/cua
Length of output: 430
🏁 Script executed:
Repository: trycua/cua
Length of output: 36
🏁 Script executed:
Repository: trycua/cua
Length of output: 1717
🏁 Script executed:
Repository: trycua/cua
Length of output: 724
🏁 Script executed:
Repository: trycua/cua
Length of output: 735
🏁 Script executed:
Repository: trycua/cua
Length of output: 1172
🏁 Script executed:
Repository: trycua/cua
Length of output: 157
🏁 Script executed:
Repository: trycua/cua
Length of output: 86
🏁 Script executed:
Repository: trycua/cua
Length of output: 38
🏁 Script executed:
Repository: trycua/cua
Length of output: 6508
🏁 Script executed:
Repository: trycua/cua
Length of output: 3191
🏁 Script executed:
Repository: trycua/cua
Length of output: 132
🏁 Script executed:
Repository: trycua/cua
Length of output: 154
🏁 Script executed:
Repository: trycua/cua
Length of output: 36
🏁 Script executed:
Repository: trycua/cua
Length of output: 151
🏁 Script executed:
Repository: trycua/cua
Length of output: 6016
Guard structured parsing when the final assistant text isn't valid JSON.
This block unconditionally calls
model_validate_json(...)without error handling. When a provider like Gemini ignores or drops the schema request (as confirmed inlibs/python/agent/agent/loops/gemini.pyat lines 712-713), the run fails at the very end with an unhandledValidationError, even though prior results have already been yielded to the caller. Catch the validation failure and skip parsing when the last assistant message is not valid JSON.Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents