Skip to content

fix(qemu): add overlay support to Windows and Linux containers #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NikkeTryHard wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(qemu): add overlay support to Windows and Linux containers #1255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e06ba05
fix(qemu): add overlay support to Windows and Linux containers
NikkeTryHard Apr 1, 2026
322f0ed
fix(qemu): exit on overlay copy failure
NikkeTryHard Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions libs/qemu-docker/linux/src/entry.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,21 @@ cleanup() {
# Install trap for signals
trap cleanup SIGTERM SIGINT SIGHUP SIGQUIT

# Overlay mode: /golden mounted read-only, /storage starts empty
if [ -d "/golden" ] && [ -z "$(ls -A /storage 2>/dev/null)" ]; then
echo "Overlay mode detected, setting up copy-on-write..."
if cp -al /golden/. /storage/ 2>/dev/null; then
echo "Overlay setup complete (hard links)."
else
echo "Hard links not supported, falling back to full copy..."
if ! cp -a /golden/. /storage/; then
echo "ERROR: overlay copy failed, cannot proceed."
exit 1
fi
echo "Overlay setup complete (full copy)."
fi
fi

# Start the VM in the background
echo "Starting Ubuntu VM..."
/usr/bin/tini -s /run/entry.sh &
Expand Down
15 changes: 15 additions & 0 deletions libs/qemu-docker/windows/src/entry.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,21 @@ cleanup() {
# Install trap for signals
trap cleanup SIGTERM SIGINT SIGHUP SIGQUIT

# Overlay mode: /golden mounted read-only, /storage starts empty
if [ -d "/golden" ] && [ -z "$(ls -A /storage 2>/dev/null)" ]; then
echo "Overlay mode detected, setting up copy-on-write..."
if cp -al /golden/. /storage/ 2>/dev/null; then
echo "Overlay setup complete (hard links)."
else
echo "Hard links not supported, falling back to full copy..."
if ! cp -a /golden/. /storage/; then
echo "ERROR: overlay copy failed, cannot proceed."
exit 1
fi
echo "Overlay setup complete (full copy)."
fi
fi

# Create windows.boot file if it doesn't exist (required for proper boot)
if [ -d "/storage" -a ! -f "/storage/windows.boot" ]; then
echo "Creating windows.boot file in /storage..."
Expand Down