NAS-141230 / 27.0.0-BETA.1 / Fix use-after-free in NVDIMM pmem driver DMA#287
Merged
Conversation
bio_for_each_bvec() accesses bio after the last loop iteration. There is a chance that due to context switching by that time the pmem_dma_callback() will already be called and the bio will be freed. To avoid that access break out of the loop explicitly.
bugclerk
changed the title
ixhamza
approved these changes
Jun 4, 2026
ixhamza
left a comment
ixhamza
left a comment
Member
There was a problem hiding this comment.
LGTM. I think this can be backported to truenas/linux-6.12 as well, since the NAS ticket has the hf_want label and the branch is now actively maintained.
|
This PR has been merged and conversations have been locked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bio_for_each_bvec() accesses bio after the last loop iteration. There is a chance that due to context switching by that time the pmem_dma_callback() will already be called and the bio will be freed. To avoid that access break out of the loop explicitly.