Lazily resolve credentials in SqlStage and minor Iceberg credential handling refactor#29440
Queued
JohnFitzpatrick44 wants to merge 2 commits into
Queued
Lazily resolve credentials in SqlStage and minor Iceberg credential handling refactor#29440JohnFitzpatrick44 wants to merge 2 commits into
SqlStage and minor Iceberg credential handling refactor#29440JohnFitzpatrick44 wants to merge 2 commits into
Conversation
JohnFitzpatrick44
force-pushed
the
jcf/refactor-cred-handling
branch
from
79f10a9 to
9eba7cd
Compare
Use a Supplier to resolve creds lazily in SqlStage. This allows the use of creds that are created post-stage creation, e.g. per-split vended credentials.
Moves the cred cache and related methods to a separate IcebergTableCredentialsProvider class to simplify credential handling.
JohnFitzpatrick44
force-pushed
the
jcf/refactor-cred-handling
branch
from
9eba7cd to
5f1607c
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR contains two orthogonal commits:
SqlStageto be a supplier, so that they can be resolved lazily after stage creationIcebergMetadatato use a separate provider classTogether, these changes put us in a better position to start handling vended credentials that are vended post-stage creation, e.g. per-split.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: