Use org.apache.iceberg.rest.RESTCatalogServlet#29430
Queued
ebyhr wants to merge 1 commit into
Queued
Conversation
Member
Author
|
/test-with-secrets sha=4a2333973a8d238483d44e9420426c7fc648e1fa |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/25723910499 |
electrum
approved these changes
May 12, 2026
Member
electrum
left a comment
electrum
left a comment
There was a problem hiding this comment.
Thanks for fixing this. We forked this back when we updated to jakarta.servlet because they were still using javax.servlet.
Member
|
FYI, an easier way to run your own PRs with secrets is to push the branch to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed that the copied RestCatalogServlet is outdated when I was testing.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.