Add azure.max-error-retries configuration property for Azure file system#29422
Open
p3tr0sz wants to merge 2 commits into
Open
Add azure.max-error-retries configuration property for Azure file system#29422p3tr0sz wants to merge 2 commits into
p3tr0sz wants to merge 2 commits into
Conversation
p3tr0sz
force-pushed
the
p3tr0sz/add-azure-retries-support
branch
from
04236ff to
9cb68a7
Compare
Add exponential-backoff retry support to the Azure filesystem connector by wiring RequestRetryOptions into both BlobContainerClientBuilder and DataLakeServiceClientBuilder. The number of retries is configurable via azure.max-error-retries (default: 4, matching the Azure SDK default). The exchange filesystem connector already uses this pattern; this aligns the main filesystem connector with the same approach.
p3tr0sz
force-pushed
the
p3tr0sz/add-azure-retries-support
branch
from
9cb68a7 to
afbcde7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
azure.max-error-retriesconfiguration property to the Azure filesystem connector. WiresRequestRetryOptionswith exponential backoff into bothBlobContainerClientBuilderandDataLakeServiceClientBuilder. Defaults to4, which matches the Azure SDK built-in default - so existing behavior is unchanged unless the property is explicitly set.The exchange filesystem connector (
trino-exchange-filesystem) already uses this pattern viaExchangeAzureConfig.getMaxErrorRetries(); this PR aligns the main filesystem connector with the same approach.Additional context and related issues
The Azure SDK adds a default
RequestRetryPolicyto all clients, but it is not configurable through the filesystem connector today. Operators encountering transient Azure errors (connection resets, rate limiting) have no knob to increase retry attempts without patching the connector.This was observed in production under high ADLS concurrency, where transient connection failures increased. Following the connection pool improvements in #29284, configurable retries provide an additional layer of resilience for operators hitting transient Azure errors under load.
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: