Add cancel button to preview UI#29315
Conversation
|
@sajjoseph can you also test this ? |
mosabua
left a comment
There was a problem hiding this comment.
Overall pretty much good to go .. just some minor things to figure out.
|
Also one more thought .. in case I understand this correctly.. Preempt only applies to queries that are not yet running So could we not just have one button that says "Stop processing" or something .. and it does the right thing depending on the the query? |
Agree, makes sense |
ccbe9fb to
ae8ce88
Compare
ae8ce88 to
83a38aa
Compare
|
@mosabua @RoeyoOgen , I looked through the backend java code and I think the only difference between kill and preempt is the message. Both paths call the same Given that I combined the two actions into a single let me know your thoughts.
...
|
85ed64c to
c99461f
Compare
|
I like the cancel query approach to combine the actions. |
c99461f to
0bd9625
Compare
|
Just fyi @koszti .. I rebased and pushed to test and potentially merge |
|
@koszti I am getting build failures locally .. can you check? |
0bd9625 to
36cdaa5
Compare
|
@mosabua I fixed the tests, everything is green now |
|
@mosabua do you know why this PR removed from the merge queue? It says build-success is failed (https://github.com/trinodb/trino/actions/runs/25678587154/job/75388409099), but all CI checks passed. Am I missing something? |
|
The queue is weird .. if it fails even an unrelated test it gets bumped off it seems .. I put it back on the queue |
36cdaa5 to
f6c8fc8
Compare
The section should be |


Description
Add Preempt and Kill control buttons to the preview query overview header.
Screenshots:
..
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: