Skip to content

Minor fixes to NEAREST support #29188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kasiafi merged 3 commits into from
Apr 22, 2026
Merged

Minor fixes to NEAREST support #29188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf18199
Keep NEAREST keyword entries alphabetized
kasiafi Apr 21, 2026
b4ce926
Fix NEAREST fallback planner error message
kasiafi Apr 21, 2026
0c006e6
Add missing blank line after NEAREST docs section
kasiafi Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/trino-grammar/src/main/antlr4/io/trino/grammar/sql/SqlBase.g4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1057,7 +1057,7 @@ nonReserved
| KEEP | KEY | KEYS
| LANGUAGE | LAST | LATERAL | LEADING | LEAVE | LEVEL | LIMIT | LOCAL | LOGICAL | LOOP
| MAP | MATCH | MATCHED | MATCHES | MATCH_RECOGNIZE | MATERIALIZED | MEASURES | MERGE | MINUTE | MONTH
| NESTED | NEXT | NFC | NFD | NEAREST | NFKC | NFKD | NO | NONE | NULLIF | NULLS
| NEAREST | NESTED | NEXT | NFC | NFD | NFKC | NFKD | NO | NONE | NULLIF | NULLS
| OBJECT | OF | OFFSET | OMIT | ONE | ONLY | OPTION | ORDINALITY | OUTPUT | OVER | OVERFLOW
| PARTITION | PARTITIONS | PASSING | PAST | PATH | PATTERN | PER | PERIOD | PERMUTE | PLAN | POSITION | PRECEDING | PRECISION | PRIVILEGES | PROPERTIES | PRUNE
| QUOTES
Expand Down Expand Up @@ -1235,9 +1235,9 @@ MERGE: 'MERGE';
MINUTE: 'MINUTE';
MONTH: 'MONTH';
NATURAL: 'NATURAL';
NEAREST: 'NEAREST';
NESTED: 'NESTED';
NEXT: 'NEXT';
NEAREST: 'NEAREST';
NFC : 'NFC';
NFD : 'NFD';
NFKC : 'NFKC';
Expand Down
2 changes: 1 addition & 1 deletion core/trino-grammar/src/test/java/io/trino/grammar/sql/TestSqlKeywords.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,8 @@ public void test()
"MINUTE",
"MONTH",
"NATURAL",
"NESTED",
"NEAREST",
"NESTED",
"NEXT",
"NFC",
"NFD",
Expand Down
2 changes: 1 addition & 1 deletion core/trino-main/src/main/java/io/trino/sql/planner/RelationPlanner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,7 +880,7 @@ protected RelationPlan visitLateral(Lateral node, Void context)
@Override
protected RelationPlan visitNearest(Nearest node, Void context)
{
throw semanticException(NOT_SUPPORTED, node, "NEAREST is only supported on the right side of CROSS JOIN, LEFT JOIN, or an implicit join");
throw semanticException(NOT_SUPPORTED, node, "NEAREST is only supported on the right side of CROSS JOIN, INNER JOIN, LEFT JOIN, or an implicit join");
}

@Override
Expand Down
1 change: 1 addition & 0 deletions docs/src/main/sphinx/sql/select.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1594,6 +1594,7 @@ NEAREST (...) ON TRUE`, implicit comma joins with `NEAREST (...)`, and
`LEFT JOIN NEAREST (...) ON TRUE`.
`JOIN USING`, `NATURAL JOIN`, and join conditions other than `ON TRUE` are not
supported for `NEAREST`.

### Qualifying column names

When two relations in a join have columns with the same name, the column
Expand Down