fix: Preserve table privileges on Iceberg HMS/file metastore commit#29166
Open
laserninja wants to merge 1 commit intotrinodb:masterfrom
Open
fix: Preserve table privileges on Iceberg HMS/file metastore commit#29166laserninja wants to merge 1 commit intotrinodb:masterfrom
laserninja wants to merge 1 commit intotrinodb:masterfrom
Conversation
ebyhr
reviewed
Apr 20, 2026
Member
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
Can you add a test?
Please follow the commit message guideline and the PR template.
Previously, every ALTER or DML commit on an Iceberg table backed by HMS or file metastore rebuilt PrincipalPrivileges from scratch using only the table owner, silently wiping any grants made via GRANT ... TO USER. Read the existing privileges from the metastore via listTablePrivileges and pass them through to replaceTable so that object-level grants survive table metadata updates.
laserninja
force-pushed
the
fix/29160-preserve-table-privileges-on-alter
branch
from
d874250 to
1ca8651
Compare
Contributor
Author
|
Done, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, every ALTER or DML commit on an Iceberg table backed by HMS (or file metastore) rebuilt PrincipalPrivileges from scratch using only the table owner, silently wiping any grants made via GRANT ... TO USER.
Read the existing privileges from the metastore via listTablePrivileges and pass them through to replaceTable so that object-level grants survive table metadata updates.
Fixes #29160