Skip to content

Close Reader in JsonInputFunctions#29130

Closed
tejasae-afk wants to merge 1 commit intotrinodb:masterfrom
tejasae-afk:fix/close-reader-in-jsoninputfunct
Closed

Close Reader in JsonInputFunctions#29130
tejasae-afk wants to merge 1 commit intotrinodb:masterfrom
tejasae-afk:fix/close-reader-in-jsoninputfunct

Conversation

@tejasae-afk
Copy link
Copy Markdown

This in JsonInputFunctions only surfaces in the edge case, so may not be a priority. The resource opened there can leak if JsonInputFunctions exits on an error path. this patch moves the allocation into try-with-resources so cleanup happens on every exit path.

Happy to revise the approach or close this if it doesn’t fit — you know the codebase far better than I do.

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Apr 15, 2026

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack.

@github-actions github-actions Bot added the stale label May 7, 2026
@martint
Copy link
Copy Markdown
Member

martint commented May 7, 2026

Thanks @tejasae-afk. There's no resource leak in this case. The reader is an ephemeral view over an in-memory byte sequence (Slice).

@martint martint closed this May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants