Remove "native" from file system configs#29070
Merged
Merged
Conversation
github-actions
Bot
added
docs
hudi
electrum
force-pushed
the
user/electrum/fsnative
branch
from
e86fd75 to
2e93037
Compare
Member
Author
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
📝 WalkthroughWalkthroughThis PR renames native filesystem enablement properties from Possibly related PRs
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.42.1)plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeConnectorTest.javaThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/DeltaLakeQueryRunner.java`:
- Around line 119-122: The builder method Builder.addS3Properties sets
"fs.s3.enabled" which bypasses the existing filesystem-detection guard and
causes the guard (the code that adds "fs.hadoop.enabled=true") to mis-detect the
native FS; update Builder.addS3Properties to also set the legacy/configuration
key that the guard expects (so the guard recognizes the configured S3 FS) or
modify the guard to check the new "fs.s3.enabled" key; specifically, either add
the additional property the guard reads (e.g., also put "fs.s3a.enabled" or the
exact key used by the guard) when calling addDeltaProperties, or change the
guard's detection code to look for "fs.s3.enabled" in addition to its current
checks (refer to addDeltaProperties and the filesystem-detection guard code).
In
`@plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/IcebergQueryRunner.java`:
- Line 281: The fallback detection currently only checks keys using
key.startsWith("fs.native-") so new keys like "fs.s3.enabled" are ignored;
update the condition in IcebergQueryRunner where the properties loop checks
fs.native- (the key.startsWith("fs.native-") check) to also treat keys that
follow the "fs.<provider>.enabled" pattern as native FS activation (for example:
key.startsWith("fs.native-") || (key.startsWith("fs.") &&
key.endsWith(".enabled"))). Apply the same change for all similar checks
referenced in this file (the occurrences noted around the existing
startsWith("fs.native-") checks).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 97ef3e97-2ea8-4aa5-b7c2-2e40d6d8f197
📒 Files selected for processing (70)
docs/src/main/sphinx/connector/redshift.mddocs/src/main/sphinx/object-storage.mddocs/src/main/sphinx/object-storage/file-system-azure.mddocs/src/main/sphinx/object-storage/file-system-gcs.mddocs/src/main/sphinx/object-storage/file-system-local.mddocs/src/main/sphinx/object-storage/file-system-s3.mddocs/src/main/sphinx/object-storage/metastores.mdlib/trino-filesystem-manager/src/main/java/io/trino/filesystem/manager/FileSystemConfig.javalib/trino-filesystem-manager/src/test/java/io/trino/filesystem/manager/TestFileSystemConfig.javaplugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/DeltaLakeQueryRunner.javaplugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeAdlsConnectorSmokeTest.javaplugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeAdlsStorage.javaplugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeConnectorTest.javaplugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeGcsConnectorSmokeTest.javaplugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeMinioAndHmsConnectorSmokeTest.javaplugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeMinioAndLockBasedSynchronizerSmokeTest.javaplugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakePreferredPartitioning.javaplugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeSharedHiveMetastoreWithViews.javaplugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/metastore/glue/TestDeltaS3AndGlueMetastoreTest.javaplugin/trino-hive/src/test/java/io/trino/plugin/hive/TestHiveCustomCatalogConnectorSmokeTest.javaplugin/trino-hive/src/test/java/io/trino/plugin/hive/TestHiveS3AndGlueMetastoreTest.javaplugin/trino-hive/src/test/java/io/trino/plugin/hive/gcs/GcsHiveQueryRunner.javaplugin/trino-hive/src/test/java/io/trino/plugin/hive/metastore/thrift/TestHiveMetastoreCatalogs.javaplugin/trino-hive/src/test/java/io/trino/plugin/hive/s3/S3HiveQueryRunner.javaplugin/trino-hive/src/test/java/io/trino/plugin/hive/s3/TestS3FileSystemAccessOperations.javaplugin/trino-hudi/src/test/java/io/trino/plugin/hudi/HudiQueryRunner.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergMinioConnectorSmokeTest.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergMinioOrcConnectorTest.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/IcebergQueryRunner.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergAbfsConnectorSmokeTest.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergGcsConnectorSmokeTest.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergInvalidCompressionCodecs.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergMaterializedViewExpiredSnapshotCleanup.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergMotoConnectorSmokeTest.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergParquetWithBloomFiltersMixedCase.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergPartitionEvolutionOnSameColumn.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergReadVersionedTableByTemporal.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestSharedHiveThriftMetastore.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/glue/TestIcebergS3AndGlueMetastoreTest.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/hms/TestIcebergHiveCatalogWithoutLock.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/rest/TestIcebergBigLakeMetastoreConnectorSmokeTest.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/rest/TestIcebergS3TablesConnectorSmokeTest.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/rest/TestIcebergS3VendingRestCatalogConnectorSmokeTest.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/snowflake/TestIcebergSnowflakeCatalogConnectorSmokeTest.javaplugin/trino-lakehouse/src/test/java/io/trino/plugin/lakehouse/BaseLakehouseConnectorSmokeTest.javaplugin/trino-lakehouse/src/test/java/io/trino/plugin/lakehouse/TestLakehouseConnectorTest.javaplugin/trino-lakehouse/src/test/java/io/trino/plugin/lakehouse/TestLakehouseFileConnectorSmokeTest.javaplugin/trino-lakehouse/src/test/java/io/trino/plugin/lakehouse/TestLakehouseMotoConnectorSmokeTest.javatesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-azure/delta.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-azure/hive.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-azure/iceberg.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-gcs/delta.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-gcs/hive.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-gcs/iceberg.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-hive4/trino/catalog/hive.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-iceberg-minio-cached/iceberg.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-minio-data-lake-cached/delta.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-minio-data-lake-task-retries-filesystem/iceberg.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-minio-data-lake/delta.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-minio-data-lake/hive.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-minio-data-lake/iceberg.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/singlenode-delta-lake-databricks/delta.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/singlenode-delta-lake-databricks/hive.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/singlenode-delta-lake-oss/delta.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/singlenode-delta-lake-oss/hive.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/singlenode-hive-hudi-redirections/hudi.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/singlenode-hudi/hudi.propertiestesting/trino-server-dev/etc/catalog/delta.propertiestesting/trino-server-dev/etc/catalog/hudi.propertiestesting/trino-tests/src/test/java/io/trino/sql/planner/IcebergCostBasedPlanTestSetup.java
electrum
force-pushed
the
user/electrum/fsnative
branch
from
2e93037 to
4b90c9c
Compare
There was a problem hiding this comment.
Pull request overview
Renames the “native” filesystem enablement configuration properties to shorter fs.<backend>.enabled names across tests, dev/product configs, and documentation, while keeping backward compatibility via legacy config mappings.
Changes:
- Rename catalog/config properties from
fs.native-*.enabledtofs.*.enabledacross test and dev/product environments. - Add
@LegacyConfigmappings inFileSystemConfigand add a unit test asserting deprecated equivalence. - Update object storage documentation to reference the new property names.
Reviewed changes
Copilot reviewed 70 out of 70 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| testing/trino-tests/src/test/java/io/trino/sql/planner/IcebergCostBasedPlanTestSetup.java | Switch Iceberg test setup to fs.s3.enabled. |
| testing/trino-server-dev/etc/catalog/hudi.properties | Update dev Hudi catalog to fs.s3.enabled. |
| testing/trino-server-dev/etc/catalog/delta.properties | Update dev Delta catalog to fs.s3.enabled. |
| testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/singlenode-hudi/hudi.properties | Update product test env config to fs.s3.enabled. |
| testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/singlenode-hive-hudi-redirections/hudi.properties | Update product test env config to fs.s3.enabled. |
| testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/singlenode-delta-lake-oss/hive.properties | Update product test env config to fs.s3.enabled. |
| testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/singlenode-delta-lake-oss/delta.properties | Update product test env config to fs.s3.enabled. |
| testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/singlenode-delta-lake-databricks/hive.properties | Update product test env config to fs.s3.enabled. |
| testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/singlenode-delta-lake-databricks/delta.properties | Update product test env config to fs.s3.enabled. |
| testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-minio-data-lake/iceberg.properties | Update product test env config to fs.s3.enabled. |
| testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-minio-data-lake/hive.properties | Update product test env config to fs.s3.enabled. |
| testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-minio-data-lake/delta.properties | Update product test env config to fs.s3.enabled. |
| testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-minio-data-lake-task-retries-filesystem/iceberg.properties | Update product test env config to fs.s3.enabled. |
| testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-minio-data-lake-cached/delta.properties | Update product test env config to fs.s3.enabled. |
| testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-iceberg-minio-cached/iceberg.properties | Update cached Iceberg env config to fs.s3.enabled. |
| testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-hive4/trino/catalog/hive.properties | Update Hive4 env config to fs.s3.enabled. |
| testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-gcs/iceberg.properties | Update GCS env config to fs.gcs.enabled. |
| testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-gcs/hive.properties | Update GCS env config to fs.gcs.enabled. |
| testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-gcs/delta.properties | Update GCS env config to fs.gcs.enabled. |
| testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-azure/iceberg.properties | Update Azure env config to fs.azure.enabled. |
| testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-azure/hive.properties | Update Azure env config to fs.azure.enabled. |
| testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-azure/delta.properties | Update Azure env config to fs.azure.enabled. |
| plugin/trino-lakehouse/src/test/java/io/trino/plugin/lakehouse/TestLakehouseMotoConnectorSmokeTest.java | Update Lakehouse Moto test to fs.s3.enabled. |
| plugin/trino-lakehouse/src/test/java/io/trino/plugin/lakehouse/TestLakehouseFileConnectorSmokeTest.java | Update Lakehouse file-metastore test to fs.s3.enabled. |
| plugin/trino-lakehouse/src/test/java/io/trino/plugin/lakehouse/TestLakehouseConnectorTest.java | Update Lakehouse connector test to fs.s3.enabled. |
| plugin/trino-lakehouse/src/test/java/io/trino/plugin/lakehouse/BaseLakehouseConnectorSmokeTest.java | Update base Lakehouse smoke test to fs.s3.enabled. |
| plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestSharedHiveThriftMetastore.java | Update Iceberg thrift metastore tests to fs.s3.enabled. |
| plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergReadVersionedTableByTemporal.java | Update Iceberg temporal-version test to fs.s3.enabled. |
| plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergPartitionEvolutionOnSameColumn.java | Update Iceberg partition evolution test to fs.s3.enabled. |
| plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergParquetWithBloomFiltersMixedCase.java | Update Iceberg parquet bloom test to fs.s3.enabled. |
| plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergMotoConnectorSmokeTest.java | Update Iceberg Moto smoke test to fs.s3.enabled. |
| plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergMaterializedViewExpiredSnapshotCleanup.java | Update MV cleanup test to fs.s3.enabled. |
| plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergInvalidCompressionCodecs.java | Update invalid codec test to fs.s3.enabled. |
| plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergGcsConnectorSmokeTest.java | Update Iceberg GCS smoke test to fs.gcs.enabled. |
| plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergAbfsConnectorSmokeTest.java | Update Iceberg ABFS smoke test to fs.azure.enabled. |
| plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/IcebergQueryRunner.java | Update Iceberg query runner example configs to new keys. |
| plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/snowflake/TestIcebergSnowflakeCatalogConnectorSmokeTest.java | Update Snowflake catalog smoke test to fs.s3.enabled. |
| plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/rest/TestIcebergS3VendingRestCatalogConnectorSmokeTest.java | Update REST catalog S3 vending test to fs.s3.enabled. |
| plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/rest/TestIcebergS3TablesConnectorSmokeTest.java | Update S3 Tables REST test to fs.s3.enabled. |
| plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/rest/TestIcebergBigLakeMetastoreConnectorSmokeTest.java | Update BigLake/GCS REST test to fs.gcs.enabled. |
| plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/hms/TestIcebergHiveCatalogWithoutLock.java | Update HMS test to fs.s3.enabled. |
| plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/glue/TestIcebergS3AndGlueMetastoreTest.java | Update Glue metastore test to fs.s3.enabled. |
| plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergMinioOrcConnectorTest.java | Update MinIO ORC base test to fs.s3.enabled. |
| plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergMinioConnectorSmokeTest.java | Update MinIO smoke test to fs.s3.enabled. |
| plugin/trino-hudi/src/test/java/io/trino/plugin/hudi/HudiQueryRunner.java | Update Hudi query runner to fs.s3.enabled. |
| plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestHiveS3AndGlueMetastoreTest.java | Update Hive Glue test to fs.s3.enabled. |
| plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestHiveCustomCatalogConnectorSmokeTest.java | Update Hive custom-catalog smoke test to fs.s3.enabled. |
| plugin/trino-hive/src/test/java/io/trino/plugin/hive/s3/TestS3FileSystemAccessOperations.java | Update Hive S3 FS operations test to fs.s3.enabled. |
| plugin/trino-hive/src/test/java/io/trino/plugin/hive/s3/S3HiveQueryRunner.java | Update S3 Hive query runner to fs.s3.enabled. |
| plugin/trino-hive/src/test/java/io/trino/plugin/hive/metastore/thrift/TestHiveMetastoreCatalogs.java | Update thrift metastore catalogs test to fs.s3.enabled. |
| plugin/trino-hive/src/test/java/io/trino/plugin/hive/gcs/GcsHiveQueryRunner.java | Update GCS Hive query runner to fs.gcs.enabled. |
| plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeSharedHiveMetastoreWithViews.java | Update shared metastore test to fs.s3.enabled. |
| plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakePreferredPartitioning.java | Update preferred partitioning test to fs.s3.enabled. |
| plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeMinioAndLockBasedSynchronizerSmokeTest.java | Update MinIO lock synchronizer smoke test to fs.s3.enabled. |
| plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeMinioAndHmsConnectorSmokeTest.java | Update MinIO/HMS smoke test configs to fs.s3.enabled. |
| plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeGcsConnectorSmokeTest.java | Update Delta GCS smoke test to fs.gcs.enabled. |
| plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeConnectorTest.java | Update Delta connector test to fs.s3.enabled. |
| plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeAdlsStorage.java | Update ADLS storage test to fs.azure.enabled. |
| plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeAdlsConnectorSmokeTest.java | Update ADLS smoke test to fs.azure.enabled. |
| plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/metastore/glue/TestDeltaS3AndGlueMetastoreTest.java | Update Delta+Glue metastore test to fs.s3.enabled. |
| plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/DeltaLakeQueryRunner.java | Update Delta query runner S3 properties to fs.s3.enabled. |
| lib/trino-filesystem-manager/src/test/java/io/trino/filesystem/manager/TestFileSystemConfig.java | Update config mapping test and add deprecated-equivalence coverage. |
| lib/trino-filesystem-manager/src/main/java/io/trino/filesystem/manager/FileSystemConfig.java | Add @LegacyConfig aliases and new @Config keys without native-. |
| docs/src/main/sphinx/object-storage/metastores.md | Update BigLake example to fs.gcs.enabled. |
| docs/src/main/sphinx/object-storage/file-system-s3.md | Update S3 docs to fs.s3.enabled. |
| docs/src/main/sphinx/object-storage/file-system-local.md | Update local FS docs to fs.local.enabled. |
| docs/src/main/sphinx/object-storage/file-system-gcs.md | Update GCS docs to fs.gcs.enabled. |
| docs/src/main/sphinx/object-storage/file-system-azure.md | Update Azure docs to fs.azure.enabled. |
| docs/src/main/sphinx/object-storage.md | Update object storage overview property table to new keys. |
| docs/src/main/sphinx/connector/redshift.md | Update Redshift docs to reference fs.s3.enabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
electrum
force-pushed
the
user/electrum/fsnative
branch
from
4b90c9c to
bda0a3c
Compare
Member
Author
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
Member
Author
|
@coderabbitai resolve |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@plugin/trino-hive/src/test/java/io/trino/plugin/hive/HiveQueryRunner.java`:
- Around line 238-240: The current check on hiveProperties only looks for new
keys via key.matches("fs\\.(azure|gcs|s3|local|hadoop)\\.enabled") and will
wrongly inject "fs.hadoop.enabled" when callers use deprecated keys; update the
predicate used in the
hiveProperties.buildOrThrow().keySet().stream().noneMatch(...) so it treats
deprecated "fs.native-<provider>.enabled" keys as present too (e.g., expand the
regex to include "fs\\.native-(azure|gcs|s3|local|hadoop)\\.enabled" or combine
two matches) before falling back to
hiveProperties.put("fs.hadoop.enabled","true") to preserve the legacy behavior.
In
`@plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/IcebergQueryRunner.java`:
- Around line 177-179: The fallback that auto-adds "fs.hadoop.enabled" in
IcebergQueryRunner checks only for active provider keys matching
"fs.(azure|gcs|s3|local|hadoop).enabled" and therefore ignores legacy keys like
"fs.native-azure.enabled", causing unintended insertion; update the condition in
IcebergQueryRunner where icebergProperties.buildOrThrow() is inspected (the
block that currently calls .noneMatch(key ->
key.matches("fs\\.(azure|gcs|s3|local|hadoop)\\.enabled"))) to also consider
deprecated keys by testing for either pattern (e.g., accept keys matching
"fs\\.native-(azure|gcs|s3|local|hadoop)\\.enabled" in addition to the existing
pattern) so that the fallback suppression recognizes legacy provider flags and
avoids adding "fs.hadoop.enabled" incorrectly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a611d126-e2ee-46a0-a52b-ee9dea70ffdb
📒 Files selected for processing (74)
docs/src/main/sphinx/connector/redshift.mddocs/src/main/sphinx/object-storage.mddocs/src/main/sphinx/object-storage/file-system-azure.mddocs/src/main/sphinx/object-storage/file-system-gcs.mddocs/src/main/sphinx/object-storage/file-system-local.mddocs/src/main/sphinx/object-storage/file-system-s3.mddocs/src/main/sphinx/object-storage/metastores.mdlib/trino-filesystem-manager/src/main/java/io/trino/filesystem/manager/FileSystemConfig.javalib/trino-filesystem-manager/src/test/java/io/trino/filesystem/manager/TestFileSystemConfig.javaplugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/DeltaLakeQueryRunner.javaplugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeAdlsConnectorSmokeTest.javaplugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeAdlsStorage.javaplugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeConnectorTest.javaplugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeGcsConnectorSmokeTest.javaplugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeMinioAndHmsConnectorSmokeTest.javaplugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeMinioAndLockBasedSynchronizerSmokeTest.javaplugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakePreferredPartitioning.javaplugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeSharedHiveMetastoreWithViews.javaplugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/metastore/glue/TestDeltaS3AndGlueMetastoreTest.javaplugin/trino-hive/src/test/java/io/trino/plugin/hive/HiveQueryRunner.javaplugin/trino-hive/src/test/java/io/trino/plugin/hive/TestHiveCustomCatalogConnectorSmokeTest.javaplugin/trino-hive/src/test/java/io/trino/plugin/hive/TestHiveS3AndGlueMetastoreTest.javaplugin/trino-hive/src/test/java/io/trino/plugin/hive/gcs/GcsHiveQueryRunner.javaplugin/trino-hive/src/test/java/io/trino/plugin/hive/metastore/thrift/TestHiveMetastoreCatalogs.javaplugin/trino-hive/src/test/java/io/trino/plugin/hive/s3/S3HiveQueryRunner.javaplugin/trino-hive/src/test/java/io/trino/plugin/hive/s3/TestS3FileSystemAccessOperations.javaplugin/trino-hudi/src/test/java/io/trino/plugin/hudi/HudiQueryRunner.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergMinioConnectorSmokeTest.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergMinioOrcConnectorTest.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/IcebergQueryRunner.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergAbfsConnectorSmokeTest.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergGcsConnectorSmokeTest.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergInvalidCompressionCodecs.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergMaterializedViewExpiredSnapshotCleanup.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergMotoConnectorSmokeTest.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergParquetWithBloomFiltersMixedCase.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergPartitionEvolutionOnSameColumn.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergReadVersionedTableByTemporal.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestSharedHiveThriftMetastore.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/glue/TestIcebergGlueCatalogConnectorSmokeTest.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/glue/TestIcebergS3AndGlueMetastoreTest.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/hms/TestIcebergHiveCatalogWithoutLock.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/rest/TestIcebergAbfsVendingRestCatalogConnectorSmokeTest.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/rest/TestIcebergBigLakeMetastoreConnectorSmokeTest.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/rest/TestIcebergGcsVendingRestCatalogConnectorSmokeTest.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/rest/TestIcebergS3TablesConnectorSmokeTest.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/rest/TestIcebergS3VendingRestCatalogConnectorSmokeTest.javaplugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/snowflake/TestIcebergSnowflakeCatalogConnectorSmokeTest.javaplugin/trino-lakehouse/src/test/java/io/trino/plugin/lakehouse/BaseLakehouseConnectorSmokeTest.javaplugin/trino-lakehouse/src/test/java/io/trino/plugin/lakehouse/TestLakehouseConnectorTest.javaplugin/trino-lakehouse/src/test/java/io/trino/plugin/lakehouse/TestLakehouseFileConnectorSmokeTest.javaplugin/trino-lakehouse/src/test/java/io/trino/plugin/lakehouse/TestLakehouseMotoConnectorSmokeTest.javatesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-azure/delta.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-azure/hive.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-azure/iceberg.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-gcs/delta.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-gcs/hive.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-gcs/iceberg.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-hive4/trino/catalog/hive.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-iceberg-minio-cached/iceberg.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-minio-data-lake-cached/delta.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-minio-data-lake-task-retries-filesystem/iceberg.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-minio-data-lake/delta.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-minio-data-lake/hive.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-minio-data-lake/iceberg.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/singlenode-delta-lake-databricks/delta.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/singlenode-delta-lake-databricks/hive.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/singlenode-delta-lake-oss/delta.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/singlenode-delta-lake-oss/hive.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/singlenode-hive-hudi-redirections/hudi.propertiestesting/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/singlenode-hudi/hudi.propertiestesting/trino-server-dev/etc/catalog/delta.propertiestesting/trino-server-dev/etc/catalog/hudi.propertiestesting/trino-tests/src/test/java/io/trino/sql/planner/IcebergCostBasedPlanTestSetup.java
✅ Files skipped from review due to trivial changes (43)
- testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-minio-data-lake-cached/delta.properties
- docs/src/main/sphinx/object-storage/file-system-local.md
- testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-gcs/delta.properties
- plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeMinioAndLockBasedSynchronizerSmokeTest.java
- plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeAdlsConnectorSmokeTest.java
- testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-minio-data-lake/delta.properties
- plugin/trino-hive/src/test/java/io/trino/plugin/hive/gcs/GcsHiveQueryRunner.java
- plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/metastore/glue/TestDeltaS3AndGlueMetastoreTest.java
- plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakePreferredPartitioning.java
- docs/src/main/sphinx/object-storage/file-system-gcs.md
- testing/trino-tests/src/test/java/io/trino/sql/planner/IcebergCostBasedPlanTestSetup.java
- plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergGcsConnectorSmokeTest.java
- plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergParquetWithBloomFiltersMixedCase.java
- plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergPartitionEvolutionOnSameColumn.java
- testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/singlenode-delta-lake-oss/hive.properties
- testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-gcs/iceberg.properties
- docs/src/main/sphinx/object-storage/file-system-s3.md
- testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-hive4/trino/catalog/hive.properties
- plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/rest/TestIcebergS3VendingRestCatalogConnectorSmokeTest.java
- plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/glue/TestIcebergS3AndGlueMetastoreTest.java
- testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-azure/delta.properties
- docs/src/main/sphinx/object-storage/file-system-azure.md
- testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-minio-data-lake/iceberg.properties
- testing/trino-server-dev/etc/catalog/hudi.properties
- plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeGcsConnectorSmokeTest.java
- plugin/trino-hudi/src/test/java/io/trino/plugin/hudi/HudiQueryRunner.java
- docs/src/main/sphinx/object-storage.md
- plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestSharedHiveThriftMetastore.java
- testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/singlenode-hudi/hudi.properties
- testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-minio-data-lake-task-retries-filesystem/iceberg.properties
- testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-azure/iceberg.properties
- testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/singlenode-delta-lake-oss/delta.properties
- testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/singlenode-delta-lake-databricks/hive.properties
- testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-minio-data-lake/hive.properties
- testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/singlenode-delta-lake-databricks/delta.properties
- testing/trino-server-dev/etc/catalog/delta.properties
- plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeSharedHiveMetastoreWithViews.java
- plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeAdlsStorage.java
- plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergInvalidCompressionCodecs.java
- plugin/trino-lakehouse/src/test/java/io/trino/plugin/lakehouse/TestLakehouseFileConnectorSmokeTest.java
- testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-gcs/hive.properties
- testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/singlenode-hive-hudi-redirections/hudi.properties
- plugin/trino-lakehouse/src/test/java/io/trino/plugin/lakehouse/TestLakehouseMotoConnectorSmokeTest.java
🚧 Files skipped from review as they are similar to previous changes (22)
- docs/src/main/sphinx/connector/redshift.md
- testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-iceberg-minio-cached/iceberg.properties
- plugin/trino-hive/src/test/java/io/trino/plugin/hive/metastore/thrift/TestHiveMetastoreCatalogs.java
- plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeMinioAndHmsConnectorSmokeTest.java
- plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergMinioOrcConnectorTest.java
- plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergMotoConnectorSmokeTest.java
- plugin/trino-hive/src/test/java/io/trino/plugin/hive/s3/S3HiveQueryRunner.java
- plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestHiveCustomCatalogConnectorSmokeTest.java
- plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergAbfsConnectorSmokeTest.java
- plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/rest/TestIcebergS3TablesConnectorSmokeTest.java
- plugin/trino-lakehouse/src/test/java/io/trino/plugin/lakehouse/BaseLakehouseConnectorSmokeTest.java
- plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergReadVersionedTableByTemporal.java
- plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/hms/TestIcebergHiveCatalogWithoutLock.java
- plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/rest/TestIcebergBigLakeMetastoreConnectorSmokeTest.java
- plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/snowflake/TestIcebergSnowflakeCatalogConnectorSmokeTest.java
- plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergMaterializedViewExpiredSnapshotCleanup.java
- plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergMinioConnectorSmokeTest.java
- plugin/trino-lakehouse/src/test/java/io/trino/plugin/lakehouse/TestLakehouseConnectorTest.java
- plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/DeltaLakeQueryRunner.java
- plugin/trino-hive/src/test/java/io/trino/plugin/hive/s3/TestS3FileSystemAccessOperations.java
- plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestHiveS3AndGlueMetastoreTest.java
- testing/trino-product-tests-launcher/src/main/resources/docker/trino-product-tests/conf/environment/multinode-azure/hive.properties
✅ Actions performedComments resolved. Approval is disabled; enable |
electrum
force-pushed
the
user/electrum/fsnative
branch
from
bda0a3c to
91d8d48
Compare
findinpath
reviewed
Apr 11, 2026
findinpath
approved these changes
Apr 11, 2026
Contributor
findinpath
left a comment
findinpath
left a comment
There was a problem hiding this comment.
I very much support this change. ❤️
It has been always a bit cumbersome to explain to non-technical users what "native" part meant in the last couple of years.
😸
wendigo
approved these changes
Apr 11, 2026
findinpath
reviewed
Apr 11, 2026
| return this; | ||
| } | ||
|
|
||
| public boolean isNativeAzureEnabled() |
Contributor
There was a problem hiding this comment.
@electrum is keeping the getters with isNativeXXXEnabled intentional?
Member
Author
There was a problem hiding this comment.
No, good catch, I missed that. (and also Codex, Copilot and Code Rabbit)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #24878
Release notes
(x) Release notes are required, with the following suggested text: