Skip to content

Test Ignite handling of decimal type with negative scale#28942

Closed
joseguzman1337 wants to merge 0 commit into
trinodb:masterfrom
joseguzman1337:test-ignite-decimal-negative-scale
Closed

Test Ignite handling of decimal type with negative scale#28942
joseguzman1337 wants to merge 0 commit into
trinodb:masterfrom
joseguzman1337:test-ignite-decimal-negative-scale

Conversation

@joseguzman1337
Copy link
Copy Markdown

Summary

Adds a unit test to TestIgniteClient that verifies IgniteClient.toColumnMapping() correctly maps decimal(p, -s) (negative scale) to decimal(p+s, 0), as implemented in the existing comment in IgniteClient.java:

precision = precision + max(-decimalDigits, 0); // Map decimal(p, -s) (negative scale) to decimal(p+s, 0).

The test uses JdbcTypeHandle with precision=5, scale=-3 and asserts the result is DECIMAL(8, 0).

Closes #28416

@cla-bot cla-bot Bot added the cla-signed label Mar 31, 2026
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@github-actions github-actions Bot added the ignite Ignite connector label Mar 31, 2026
@joseguzman1337 joseguzman1337 force-pushed the test-ignite-decimal-negative-scale branch from 0e683f7 to efd62ef Compare March 31, 2026 17:37
@joseguzman1337 joseguzman1337 force-pushed the test-ignite-decimal-negative-scale branch from 738766a to 8ec15af Compare March 31, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed ignite Ignite connector

Development

Successfully merging this pull request may close these issues.

Test Ignite handling of decimal type with negative scale

1 participant