Skip to content

Remove incorrect revapi exclusions#28934

Merged
hashhar merged 1 commit into
trinodb:masterfrom
hashhar:fix-revapi-exclusions
Mar 30, 2026
Merged

Remove incorrect revapi exclusions#28934
hashhar merged 1 commit into
trinodb:masterfrom
hashhar:fix-revapi-exclusions

Conversation

@hashhar
Copy link
Copy Markdown
Member

@hashhar hashhar commented Mar 30, 2026

Description

The revapi comparison was done against the wrong baseline artifact.

Only add one entry for ConnectorMetadata::finishRefreshMaterializedView gaining the hasNonDeterministicFunctions parameter (added in #28682).

Additional context and related issues

Fixes the pom.xml mess introduced in #28682.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

The previous revapi comparison was done against the wrong baseline artifact,
producing hundreds of spurious exclusion entries for changes already present
in the 480 release.

Keep only the single correct exclusion for the new hasNonDeterministicFunctions
parameter added to ConnectorMetadata::finishRefreshMaterializedView.
@cla-bot cla-bot Bot added the cla-signed label Mar 30, 2026
@hashhar hashhar requested review from dain and martint March 30, 2026 19:04
@hashhar hashhar merged commit a4e2d12 into trinodb:master Mar 30, 2026
194 of 196 checks passed
@hashhar hashhar deleted the fix-revapi-exclusions branch March 30, 2026 20:35
@github-actions github-actions Bot added this to the 481 milestone Mar 30, 2026
@ebyhr ebyhr mentioned this pull request Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants