Skip to content

Add tests for Iceberg $files delete-file deduplication and deletion vectors#28933

Merged
ebyhr merged 1 commit into
trinodb:masterfrom
kaveti:files-table-dedup
Apr 17, 2026
Merged

Add tests for Iceberg $files delete-file deduplication and deletion vectors#28933
ebyhr merged 1 commit into
trinodb:masterfrom
kaveti:files-table-dedup

Conversation

@kaveti
Copy link
Copy Markdown
Contributor

@kaveti kaveti commented Mar 30, 2026

Description

  • add coverage for Iceberg $files delete-file deduplication
  • add coverage for deletion vectors stored in a shared Puffin file

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot Bot added the cla-signed label Mar 30, 2026
@github-actions github-actions Bot added the iceberg Iceberg connector label Mar 30, 2026
@kaveti kaveti force-pushed the files-table-dedup branch 2 times, most recently from 3174be5 to 2399782 Compare March 31, 2026 02:25
@kaveti kaveti force-pushed the files-table-dedup branch 3 times, most recently from fa89958 to a2e9b9e Compare April 2, 2026 07:13
@kaveti kaveti force-pushed the files-table-dedup branch from a2e9b9e to 499496c Compare April 7, 2026 05:58
@github-actions github-actions Bot added the docs label Apr 7, 2026
@kaveti kaveti changed the title Add test for $files table delete file deduplication Add fields for $files table delete file deduplication Apr 9, 2026
@oskar-szwajkowski
Copy link
Copy Markdown
Contributor

Could we move forward with: #29044 ?

It adds the same fields + some more, how do folks feel about it?

@kaveti
Copy link
Copy Markdown
Contributor Author

kaveti commented Apr 10, 2026

@oskar-szwajkowski we can break it two PRs or have it in one & close this one . i'm good with anything

@oskar-szwajkowski
Copy link
Copy Markdown
Contributor

lets see how @chenjian2664 sees it

@oskar-szwajkowski
Copy link
Copy Markdown
Contributor

@kaveti my PR has been merged, feel free to rebase on top of master if you want to include some additional changes

@kaveti kaveti force-pushed the files-table-dedup branch from 499496c to d722b7a Compare April 16, 2026 19:36
@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Apr 16, 2026

Please update both PR title & description, squash commits into one.

@kaveti kaveti force-pushed the files-table-dedup branch from d722b7a to e2031a2 Compare April 17, 2026 11:40
@kaveti kaveti changed the title Add fields for $files table delete file deduplication Add tests for Iceberg $files delete-file deduplication and deletion vectors Apr 17, 2026
@ebyhr ebyhr force-pushed the files-table-dedup branch from e2031a2 to 4355b65 Compare April 17, 2026 13:04
@ebyhr ebyhr force-pushed the files-table-dedup branch from 4355b65 to f5b75c0 Compare April 17, 2026 13:05
@ebyhr ebyhr merged commit 8f376af into trinodb:master Apr 17, 2026
44 checks passed
@ebyhr ebyhr mentioned this pull request Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants