Fix QueryList timeout typing and clean up compile-commits config#28802
Fix QueryList timeout typing and clean up compile-commits config#28802kkauy wants to merge 2 commits into
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
I submitted the signed CLA to cla@trino.io more than three weeks ago and also sent follow-up emails, but the verification/cla-signed check is still failing. Could someone please help confirm whether my CLA was received, or whether any additional information is needed from me? |
| MAVEN_INSTALL_OPTS="-Xmx3G -XX:+ExitOnOutOfMemoryError" | ||
| MAVEN_COMPILE_COMMITS="-B --strict-checksums --quiet -T 1C -DskipTests -Dmaven.source.skip=true -Dair.check.skip-all=true -Dmaven.javadoc.skip=true --no-snapshot-updates --no-transfer-progress" | ||
| MAVEN_COMPILE_COMMITS="-B --strict-checksums | ||
| -T 1C -DskipTests -Dmaven.source.skip=true -Dair.check.skip-all=true -Dmaven.javadoc.skip=true --no-snapshot-updates --no-transfer-progress" |
There was a problem hiding this comment.
I will keep the MAVEN_COMPILE_COMMITS line on a single line
| MAVEN_OPTS: "-Xmx512M -XX:+ExitOnOutOfMemoryError" | ||
| MAVEN_INSTALL_OPTS: "-Xmx3G -XX:+ExitOnOutOfMemoryError" | ||
| MAVEN_FAST_INSTALL: "-B -V -T 1C -DskipTests -Dmaven.source.skip=true -Dair.check.skip-all" | ||
| MAVEN_COMPILE_COMMITS: "-B --quiet -T 1C -DskipTests -Dmaven.source.skip=true -Dair.check.skip-all=true -Dmaven.javadoc.skip=true --no-snapshot-updates --no-transfer-progress" |
There was a problem hiding this comment.
I thought that --quiet was intentional. Why remove?
There was a problem hiding this comment.
restore the --quiet flag (it was removed during refactoring by mistake).
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Kept MAVEN_COMPILE_COMMITS on a single line and synced the flags between compile-commit and ci.yml, restoring --quiet and keeping --strict-checksums in both places. |
kkauy
force-pushed
the
issue-28727-webui-failure-location
branch
3 times, most recently
from
45e3f0d to
b623e53
Compare
|
Re-ran GoogleSheets test` locally and it passes. The remaining CI failure appears unrelated to this PR and may be due to an external or intermittent Google Sheets issue in CI. |
|
It looks like the Could someone please confirm whether there is anything further needed from my side for this PR, or whether the remaining failures are unrelated to the changes here? |
kkauy
force-pushed
the
issue-28727-webui-failure-location
branch
from
258cf6a to
89e68f6
Compare
|
This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack. |
3 participants
Description
This change makes two small fixes:
MAVEN_COMPILE_COMMITSconfiguration used in CI / compile-commit so the command is easier to read and its output is more useful when debugging failuresQueryListby usingReturnType<typeof setTimeout>, which is safer across environments and aligns better with TypeScript expectationsAdditional context and related issues
The CI change helps make compile-commit behavior easier to inspect when failures happen.
The Web UI change avoids relying on
numberfor the timeout handle type, which can be incorrect depending on the environment and TypeScript configuration.Release notes
(x) This is not user-visible or is docs only, and no release notes are required.