Do not wrap with Slice for comparisons and hashing#28573
Conversation
pettyjamesm
left a comment
There was a problem hiding this comment.
LGTM, once the length vs toIndex fix is made
69c56ba to
1f83054
Compare
|
Started benchmark workflow for this PR with test type =
|
|
Will be interested to see if this yields a perf difference in benchmarks, but I kind of doubt it. The slice allocation and equals method may have been inlined before yielding essentially similar code. It shouldn't hurt though, so no objections to the change as is even without a measurable lift. |
|
@pettyjamesm I doubt that but worth checking anyway :) |
Description
Saves on the allocation while comparing
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: