Skip to content

Fix table name in BaseConnectorTest #28508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Mar 3, 2026
+4 −4
Merged

Fix table name in BaseConnectorTest #28508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6208,7 +6208,7 @@ public void testColumnName()
protected void testColumnName(String columnName, boolean delimited)
{
String nameInSql = toColumnNameInSql(columnName, delimited);
String tableName = "tcn_" + nameInSql.toLowerCase(ENGLISH).replaceAll("[^a-z0-9]", "") + randomNameSuffix();
String tableName = "test_column_" + nameInSql.toLowerCase(ENGLISH).replaceAll("[^a-z0-9]", "") + randomNameSuffix();
Comment thread
chenjian2664 marked this conversation as resolved.

try {
// TODO test with both CTAS *and* CREATE TABLE + INSERT, since they use different connector API methods.
Expand Down Expand Up @@ -6252,7 +6252,7 @@ public void testAddAndDropColumnName()
protected void testAddAndDropColumnName(String columnName, boolean delimited)
{
String nameInSql = toColumnNameInSql(columnName, delimited);
String tableName = "tcn_" + nameInSql.toLowerCase(ENGLISH).replaceAll("[^a-z0-9]", "") + randomNameSuffix();
String tableName = "test_add_drop_column_" + nameInSql.toLowerCase(ENGLISH).replaceAll("[^a-z0-9]", "") + randomNameSuffix();

try {
assertUpdate(createTableSqlForAddingAndDroppingColumn(tableName, nameInSql));
Expand Down Expand Up @@ -6296,7 +6296,7 @@ public void testRenameColumnName()
protected void testRenameColumnName(String columnName, boolean delimited)
{
String nameInSql = toColumnNameInSql(columnName, delimited);
String tableName = "tcn_" + nameInSql.replaceAll("[^a-z0-9]", "") + randomNameSuffix();
String tableName = "test_rename_column_" + nameInSql.replaceAll("[^a-z0-9]", "") + randomNameSuffix();
// Use complex identifier to test a source column name when renaming columns
String sourceColumnName = "a;b$c";

Expand Down Expand Up @@ -7482,7 +7482,7 @@ private void testMaterializedViewColumnName(String columnName, boolean delimited
if (delimited) {
nameInSql = "\"" + columnName.replace("\"", "\"\"") + "\"";
}
String viewName = "tcn_" + nameInSql.toLowerCase(ENGLISH).replaceAll("[^a-z0-9]", "_") + "_" + randomNameSuffix();
String viewName = "test_mv_column_" + nameInSql.toLowerCase(ENGLISH).replaceAll("[^a-z0-9]", "_") + "_" + randomNameSuffix();

try {
assertUpdate("CREATE MATERIALIZED VIEW " + viewName + " AS SELECT 'sample value' key, 'abc' " + nameInSql);
Expand Down
Loading