Skip to content

Add random name suffix to SQL Server test tables #28506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Mar 3, 2026
+14 −0
Merged

Add random name suffix to SQL Server test tables #28506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ...n/trino-sqlserver/src/test/java/io/trino/plugin/sqlserver/TestSqlServerConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ private void testInsertWriteBulkinessWithTimestamps(String timestampType)
public void testCreateAndDropTableWithSpecialCharacterName()
{
for (String tableName : testTableNameTestData()) {
tableName = addRandomNameSuffix(tableName);
String tableNameInSql = "\"" + tableName.replace("\"", "\"\"") + "\"";
// Until https://github.com/trinodb/trino/issues/17 the table name is effectively lowercase
tableName = tableName.toLowerCase(ENGLISH);
Expand Down Expand Up @@ -215,6 +216,7 @@ public void testRenameColumnNameAdditionalTests()
public void testRenameFromToTableWithSpecialCharacterName()
{
for (String tableName : testTableNameTestData()) {
tableName = addRandomNameSuffix(tableName);
String tableNameInSql = "\"" + tableName.replace("\"", "\"\"") + "\"";
String sourceTableName = "test_rename_source_" + randomNameSuffix();
assertUpdate("CREATE TABLE " + sourceTableName + " AS SELECT 123 x", 1);
Expand Down Expand Up @@ -276,4 +278,16 @@ private List<String> testTableNameTestData()
.add("close]bracket")
.build();
}

/**
* Returns a new name with a random suffix which maintains the shape of the name.
*
* <p>In particular, the suffix is added before any trailing spaces.
*/
private static String addRandomNameSuffix(String name)
{
String trimmed = name.stripTrailing();
String trailingWhitespace = name.substring(trimmed.length());
return format("%s%s%s", trimmed, randomNameSuffix(), trailingWhitespace);
}
}