-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Read metadata and protocol information from Delta checksum files #28381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
178b1c8
7c99b4e
a4b9849
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -191,6 +191,32 @@ void testListFilesStartingFromDoubleSlashPathComponent() | |
| Location.of("file:///double/a")); | ||
| } | ||
|
|
||
| @Test | ||
| void testListFilesStartingFromHierarchicalLocationNormalization() | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The test succeeds also without the productive code changes on EmulatedListFilesStartingFromIterator.java
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Verified by reverting the iterator change locally: the test fails with |
||
| throws IOException | ||
| { | ||
| // FS canonicalizes `//` to `/`; iterator falls back to slash-collapsed prefix. | ||
| assertThat(listFilesStartingFrom( | ||
| Location.of("abfs://container@account.dfs.core.windows.net/dir//sub/_delta_log/"), | ||
| "00000000000000000000", | ||
| List.of( | ||
| entry("abfs://container@account.dfs.core.windows.net/dir/sub/_delta_log/00000000000000000000.json"), | ||
| entry("abfs://container@account.dfs.core.windows.net/dir/sub/_delta_log/00000000000000000001.checkpoint.parquet")))) | ||
| .containsExactly( | ||
| Location.of("abfs://container@account.dfs.core.windows.net/dir/sub/_delta_log/00000000000000000000.json"), | ||
| Location.of("abfs://container@account.dfs.core.windows.net/dir/sub/_delta_log/00000000000000000001.checkpoint.parquet")); | ||
|
|
||
| // startingFrom filtering still applies to the slash-collapsed remainder. | ||
| assertThat(listFilesStartingFrom( | ||
| Location.of("abfs://container@account.dfs.core.windows.net/dir//sub/_delta_log/"), | ||
| "00000000000000000001", | ||
| List.of( | ||
| entry("abfs://container@account.dfs.core.windows.net/dir/sub/_delta_log/00000000000000000000.json"), | ||
| entry("abfs://container@account.dfs.core.windows.net/dir/sub/_delta_log/00000000000000000001.checkpoint.parquet")))) | ||
| .containsExactly( | ||
| Location.of("abfs://container@account.dfs.core.windows.net/dir/sub/_delta_log/00000000000000000001.checkpoint.parquet")); | ||
| } | ||
|
|
||
| @Test | ||
| void testListFilesStartingFromIncludesAllNonAsciiFilenames() | ||
| throws IOException | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.