Skip to content

Mark Deprecated with removal for join-pushdown.with-expressions #27619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chenjian2664 wants to merge 2 commits into from
+3 −3
Closed

Mark Deprecated with removal for join-pushdown.with-expressions #27619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f80d183
Mark Deprecated with removal for `join-pushdown.with-expressions`
chenjian2664 Dec 11, 2025
7cef272
Run ci
chenjian2664 Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcMetadataConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ public boolean isComplexJoinPushdownEnabled()
return complexJoinPushdownEnabled;
}

@Deprecated
@Config("deprecated.join-pushdown.with-expressions")
Copy link
Copy Markdown
Member

@findepi findepi Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs approval from @kokosing per #27619 (comment)

@Deprecated(forRemoval = true)
Copy link
Copy Markdown
Member

@findepi findepi Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Airlift has a checker that if the setter is @Deprecated , the getter is also deprecated.
That's why both are deprecated. Let's mark both with forRemoval for consistency.

@Config("join-pushdown.with-expressions")
@ConfigDescription("Enable join pushdown with complex expressions")
public JdbcMetadataConfig setComplexJoinPushdownEnabled(boolean complexJoinPushdownEnabled)
{
Expand Down
2 changes: 1 addition & 1 deletion plugin/trino-base-jdbc/src/test/java/io/trino/plugin/jdbc/TestJdbcMetadataConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public void testExplicitPropertyMappings()
Map<String, String> properties = ImmutableMap.<String, String>builder()
.put("complex-expression-pushdown.enabled", "false")
.put("join-pushdown.enabled", "true")
.put("deprecated.join-pushdown.with-expressions", "false")
.put("join-pushdown.with-expressions", "false")
.put("aggregation-pushdown.enabled", "false")
.put("jdbc.bulk-list-columns.enabled", "true")
.put("domain-compaction-threshold", "42")
Expand Down