Fix ci workflow on master#27094
Merged
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Member
Author
|
A branch |
The ci workflow got broken in 3698755 because `dorny/paths-filter` action works out of the box on PR runs only. It can be made to work on branch push runs too (requires actions/checkout), but then it's meaningless -- there won't be any chnages anyway. Or actually can be misleading, as it will compare the branch against master, so may work surprisingly when the workflow is enabled on any other branch.
findepi
force-pushed
the
findepi/fix-ci
branch
from
4e0ab94 to
3f2fb99
Compare
wendigo
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ci workflow got broken in 3698755 (#27070)
because
dorny/paths-filteraction works out of the box on PR runsonly.
It can be made to work on branch push runs too (requires
actions/checkout), but then it's meaningless -- there won't be any
chnages anyway. Or actually can be misleading, as it will compare the
branch against master, so may work surprisingly when the workflow is
enabled on any other branch.