Skip to content

Test code-only change on CI#27071

Closed
findepi wants to merge 5 commits into
trinodb:findepi/docs-checksfrom
findepi:findepi/test-code-only-change-on-ci-aeb2ae
Closed

Test code-only change on CI#27071
findepi wants to merge 5 commits into
trinodb:findepi/docs-checksfrom
findepi:findepi/test-code-only-change-on-ci-aeb2ae

Conversation

@findepi
Copy link
Copy Markdown
Member

@findepi findepi commented Oct 23, 2025

Summary by Sourcery

Chores:

  • Add a dummy // code change comment in BlackHoleConnector.java

@cla-bot cla-bot Bot added the cla-signed label Oct 23, 2025
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Oct 23, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR adds a non-functional inline comment in BlackHoleConnector to validate the CI pipeline without altering any behavior.

File-Level Changes

Change Details Files
Inserted a placeholder comment in the BlackHoleConnector class
  • Add '// code change' comment between existing field declarations
plugin/trino-blackhole/src/main/java/io/trino/plugin/blackhole/BlackHoleConnector.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@findepi
Copy link
Copy Markdown
Member Author

findepi commented Oct 23, 2025

currently based on #27070

@github-actions github-actions Bot added the blackhole Blackhole connector label Oct 23, 2025
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@findepi findepi force-pushed the findepi/docs-checks branch from 4a631d0 to b992071 Compare October 23, 2025 12:16
@findepi findepi force-pushed the findepi/test-code-only-change-on-ci-aeb2ae branch from e721e0f to 943744a Compare October 23, 2025 13:14
@github-actions github-actions Bot added jdbc Relates to Trino JDBC driver hudi Hudi connector iceberg Iceberg connector delta-lake Delta Lake connector hive Hive connector lakehouse labels Oct 23, 2025
@findepi findepi force-pushed the findepi/test-code-only-change-on-ci-aeb2ae branch from 943744a to 2b53669 Compare October 23, 2025 13:18
@findepi findepi force-pushed the findepi/docs-checks branch from f53b204 to 223d18b Compare October 23, 2025 13:52
@findepi findepi force-pushed the findepi/docs-checks branch 2 times, most recently from 2edda65 to 9f43511 Compare October 23, 2025 15:15
@findepi findepi marked this pull request as draft October 23, 2025 15:17
@findepi findepi force-pushed the findepi/docs-checks branch from 212e26e to a0d9b10 Compare October 24, 2025 07:50
@findepi findepi deleted the branch trinodb:findepi/docs-checks October 24, 2025 11:15
@findepi findepi closed this Oct 24, 2025
@findepi findepi deleted the findepi/test-code-only-change-on-ci-aeb2ae branch October 24, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blackhole Blackhole connector cla-signed delta-lake Delta Lake connector hive Hive connector hudi Hudi connector iceberg Iceberg connector jdbc Relates to Trino JDBC driver lakehouse

Development

Successfully merging this pull request may close these issues.

1 participant