Skip to content

Temp fix for broken download link#27010

Closed
Ordinant wants to merge 3 commits into
trinodb:masterfrom
Ordinant:bw/fix-jdbc-download
Closed

Temp fix for broken download link#27010
Ordinant wants to merge 3 commits into
trinodb:masterfrom
Ordinant:bw/fix-jdbc-download

Conversation

@Ordinant
Copy link
Copy Markdown
Member

@Ordinant Ordinant commented Oct 18, 2025

Description

The download link for trino-jdbc-477.jar was broken. I tried to debug the {download_mc} macro, but it all looked right to me. As a stopgap, I just hardcoded the actual download link.

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

Summary by Sourcery

Documentation:

  • Replace the {download_mc}jdbc macro with a hardcoded hyperlink to trino-jdbc-477.jar on Maven Central

@cla-bot cla-bot Bot added the cla-signed label Oct 18, 2025
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Oct 18, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Replaces the broken {download_mc} macro in the JDBC documentation with a hardcoded URL to the trino-jdbc-477.jar as an interim solution.

File-Level Changes

Change Details Files
Replace dynamic download macro with a static Maven Central URL docs/src/main/sphinx/client/jdbc.md

Possibly linked issues

  • #N/A: The PR hardcodes the correct Maven Central link for the JDBC Jar, fixing the broken download link in the issue.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions Bot added the docs label Oct 18, 2025
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Ordinant
Copy link
Copy Markdown
Member Author

I didn't realize the old change to openmetrics.md was still on my Trino fork. The best solution is to fix {download_mc} and then throw away this PR.

@ebyhr ebyhr closed this Oct 18, 2025
@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Oct 18, 2025

It's already fixed by #26733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants