Remove deprecated gcs.use-access-token from gcs filesystem

[chenjian2664]

Description

Now we recommend to use the gcs.auth-type instead

Additional context and related issues

• Add gcs.auth-type configuration #26681

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

## Hive, Delta Lake, Iceberg, Hudi
* {{breaking}} Remove the deprecated `gcs.use-access-token` config property. ({issue}`26941`)

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR removes the deprecated gcs.use-access-token option from the GCS filesystem by marking it defunct, deleting its code paths and tests, and eliminating its documentation reference.

Entity relationship diagram for GCS filesystem config properties after removal of gcs.use-access-token

erDiagram
    GCS_FILE_SYSTEM_CONFIG {
        string gcs_auth_type
        string gcs_json_key
        string gcs_json_key_file_path
    }

Loading

Class diagram for GcsFileSystemConfig after removal of deprecated access token methods

classDiagram
class GcsFileSystemConfig {
  +AuthType authType
  +String jsonKey
  +String jsonKeyFilePath
  +GcsFileSystemConfig setAuthType(AuthType authType)
  +String getJsonKey()
  +String getJsonKeyFilePath()
  +boolean isAuthMethodValid()
  -Optional<Boolean> useGcsAccessToken
  -boolean isUseGcsAccessToken()
  -GcsFileSystemConfig setUseGcsAccessToken(boolean useGcsAccessToken)
  -boolean isAuthTypeAndGcsAccessTokenConfigured()
}
class AuthType {
}
GcsFileSystemConfig --> AuthType

Loading

File-Level Changes

Change	Details	Files
Remove deprecated gcs.use-access-token configuration handling	Add @DefunctConfig for gcs.use-access-token Delete isUseGcsAccessToken, setUseGcsAccessToken, and associated field Remove validation method isAuthTypeAndGcsAccessTokenConfigured	lib/trino-filesystem-gcs/src/main/java/io/trino/filesystem/gcs/GcsFileSystemConfig.java
Cleanup test cases removing deprecated access-token tests	Remove default config mapping of use-access-token Drop backwards-compatibility and explicit mapping tests for gcs.use-access-token Eliminate validation assertions combining auth-type and access-token	lib/trino-filesystem-gcs/src/test/java/io/trino/filesystem/gcs/TestGcsFileSystemConfig.java
Delete documentation reference for gcs.use-access-token	Remove deprecated property entry from GCS filesystem docs	docs/src/main/sphinx/object-storage/file-system-gcs.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[github-actions]

This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack.

[github-actions]

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

[ebyhr]

Could you rebase on master to resolve conflicts?

[ebyhr]

/test-with-secrets sha=f0c81d73a918612656d6df705de4916f66087037

[github-actions]

The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/20806168880