Update limit pushdown for Oracle

[codluca]

Update limit pushdown for Oracle

Change appeared after discussion on PR #26688
which is a fix for issue: Support TopN pushdown for Oracle connector #26566

Description

As Trino no longer supports Oracle version 11,
update limit pushdown from the older Oracle version (<=11) "ROWNUM <= number" syntax to the newer (>=12) "FETCH FIRST number ROWS ONLY" syntax.

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

Summary by Sourcery

Enhancements:

• Replace ROWNUM <= n syntax with FETCH FIRST n ROWS ONLY in the Oracle connector’s limit pushdown

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR refactors the Oracle connector’s limit pushdown to use the newer SQL standard FETCH FIRST syntax instead of the legacy ROWNUM approach, updating the limitFunction implementation accordingly.

Class diagram for updated OracleClient limitFunction

classDiagram
class OracleClient {
  +Optional<BiFunction<String, Long, String>> limitFunction()
}
OracleClient : limitFunction() now returns SQL using "FETCH FIRST ... ROWS ONLY" syntax

Loading

File-Level Changes

Change	Details	Files
Refactor limit pushdown SQL template to modern syntax	Replaced "SELECT * FROM () WHERE ROWNUM <= " with " FETCH FIRST ROWS ONLY"	plugin/trino-oracle/src/main/java/io/trino/plugin/oracle/OracleClient.java

Possibly linked issues

• Support TopN pushdown for Oracle connector #26566: The PR updates Oracle limit pushdown syntax from ROWNUM to FETCH FIRST, resolving the TopN pushdown issue.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[chenjian2664]

When and where should we update the release note @findepi

[findepi]

i don't think a RN is needed. AFAICT Oracle 11 was already not supported, this PR is just a code refactor.