Skip to content

Document Calendar ORC metadata limitation #26874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 2 commits into from
Oct 15, 2025
Merged

Document Calendar ORC metadata limitation #26874

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d7cfd3
Add a known limitation of ORC reader to docs.
marcinsbd Oct 8, 2025
904f303
Add a known limitation of ORC reader to docs.
marcinsbd Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/src/main/sphinx/object-storage/file-formats.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,13 @@ with ORC files performed by supported object storage connectors:
[](file-compression) is automatically performed and some details can be
configured.

Limitations:
Comment thread
marcinsbd marked this conversation as resolved.
Outdated
[Trino ignores Calendar entry in ORC file metadata.](https://github.com/trinodb/trino/issues/26865)
Comment thread
findepi marked this conversation as resolved.
As a result Trino always treats dates and timestamps as values written using
proleptic Gregorian calendar. This causes incorrect values read when reading
Copy link
Copy Markdown
Member

@mosabua mosabua Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
proleptic Gregorian calendar. This causes incorrect values read when reading
Gregorian calendar. This causes incorrect values when reading

Copy link
Copy Markdown
Member

@findepi findepi Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • proleptic is an important word, we should keep it

  • "This causes incorrect values when reading" reads as missing something.
    Incorrect values where? does the file gets broken, changed or malformed when we try to read it? or only the values reconstructed in computer memory are wrong?

date/time values before Oct 15, 1582 that were written using hybrid
Copy link
Copy Markdown
Member

@mosabua mosabua Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
date/time values before Oct 15, 1582 that were written using hybrid
values before Oct 15, 1582 that were written using hybrid

Copy link
Copy Markdown
Member

@findepi findepi Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove "date/time", but then we need to indicate which types does this apply to.
@mosabua how would you want to indicate this?

Julian-Gregorian calendar.

Comment thread
marcinsbd marked this conversation as resolved.
(parquet-format-configuration)=
## Parquet format configuration properties

Expand Down