Skip to content

Add register_table procedure usage instructions#25784

Closed
XavieLee wants to merge 1 commit into
trinodb:masterfrom
XavieLee:update/doc/register_table
Closed

Add register_table procedure usage instructions#25784
XavieLee wants to merge 1 commit into
trinodb:masterfrom
XavieLee:update/doc/register_table

Conversation

@XavieLee
Copy link
Copy Markdown
Member

Description

People try to register tables in a different location and face query failures later, add description for this function.

Additional context and related issues

#16105

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

default. The procedure is enabled only when
`iceberg.register-table-procedure.enabled` is set to `true`.

Avoid registering multiple tables with the same location.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasoning behind the recommandation is missing

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@findinpath I follow ebyhr's suggestion and remove it before. #25536 (comment)

now I have re-described it, please help review again, thanks~

Copy link
Copy Markdown
Member

@ebyhr ebyhr May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't suggesting removing the reason - the removed part isn't the "reason". It's just a protection rule.

@XavieLee XavieLee force-pushed the update/doc/register_table branch from b6abfff to a38189f Compare May 20, 2025 03:00
default. The procedure is enabled only when
`iceberg.register-table-procedure.enabled` is set to `true`.

Ensure tables are registered using their prior storage path, and avoid associating multiple tables with identical locations.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Ensure tables are registered using their prior storage path"

Users don't have to ensure that. The procedure blocks such execution either way.

@github-actions
Copy link
Copy Markdown

This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack.

@github-actions github-actions Bot added the stale label Jun 13, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 7, 2025

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

@github-actions github-actions Bot closed this Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants