Skip to content

Fix incorrect config properties in OpenLineage docs#25548

Merged
mosabua merged 1 commit into
trinodb:masterfrom
dolfinus:docs/fix-openlineage-plugin-docs
Apr 17, 2025
Merged

Fix incorrect config properties in OpenLineage docs#25548
mosabua merged 1 commit into
trinodb:masterfrom
dolfinus:docs/fix-openlineage-plugin-docs

Conversation

@dolfinus
Copy link
Copy Markdown
Contributor

@dolfinus dolfinus commented Apr 10, 2025

Description

OpenLineage integration docs was updated - there are no some parameters specified here, now they have different names.

Additional context and related issues

Release notes

(X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Apr 10, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions Bot added the docs label Apr 10, 2025
Copy link
Copy Markdown
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[OpenLineage] Fix outdated docs

Fix incorrect config properties in OpenLineage docs

https://trino.io/development/process#pull-request-and-commit-guidelines-

@dolfinus dolfinus force-pushed the docs/fix-openlineage-plugin-docs branch from 93c43a1 to f8d8198 Compare April 10, 2025 12:48
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Apr 10, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@dolfinus dolfinus changed the title [OpenLineage] Fix outdated docs Fix incorrect config properties in OpenLineage docs Apr 10, 2025
Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. Please update and I can merge. Also please send a CLA.

Comment thread docs/src/main/sphinx/admin/event-listeners-openlineage.md Outdated
@ebyhr ebyhr force-pushed the docs/fix-openlineage-plugin-docs branch from f8d8198 to 94cd71d Compare April 13, 2025 07:06
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Apr 13, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@dolfinus
Copy link
Copy Markdown
Contributor Author

Also please send a CLA.

Did this right after opening a PR, but still waiting until it is checked.

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Apr 15, 2025

We have to wait until @martint processed the CLA.

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Apr 15, 2025

@cla-bot check

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Apr 15, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Apr 15, 2025

The cla-bot has been summoned, and re-checked this pull request!

@dolfinus
Copy link
Copy Markdown
Contributor Author

@cla-bot check

@cla-bot cla-bot Bot added the cla-signed label Apr 17, 2025
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Apr 17, 2025

The cla-bot has been summoned, and re-checked this pull request!

@mosabua mosabua merged commit aaced32 into trinodb:master Apr 17, 2025
8 checks passed
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Apr 17, 2025

Thank you @dolfinus

@github-actions github-actions Bot added this to the 475 milestone Apr 17, 2025
@dolfinus dolfinus deleted the docs/fix-openlineage-plugin-docs branch April 17, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants