Skip to content

Add support for Bool type for ClickHouse connector#25337

Merged
ebyhr merged 1 commit into
trinodb:masterfrom
codeDing18:mas
Apr 18, 2025
Merged

Add support for Bool type for ClickHouse connector#25337
ebyhr merged 1 commit into
trinodb:masterfrom
codeDing18:mas

Conversation

@codeDing18
Copy link
Copy Markdown
Contributor

@codeDing18 codeDing18 commented Mar 18, 2025

Description

Fix #25130

Release notes

## ClickHouse
* Map Trino `boolean` type to ClickHouse `bool` type. ({issue}`25130`)

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Mar 18, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions Bot added the clickhouse ClickHouse connector label Mar 18, 2025
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Mar 18, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@codeDing18
Copy link
Copy Markdown
Contributor Author

@cla-bot check

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Mar 18, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Mar 18, 2025

The cla-bot has been summoned, and re-checked this pull request!

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Mar 19, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions Bot added the docs label Mar 19, 2025
@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Mar 20, 2025

@codeDing18 Did you submit CLA?

@codeDing18
Copy link
Copy Markdown
Contributor Author

@cla-bot check

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Mar 20, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Mar 20, 2025

The cla-bot has been summoned, and re-checked this pull request!

@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Mar 20, 2025

@codeDing18 check command doesn't work unless your CLA is registered.

@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Mar 20, 2025

@codeDing18 Note that CLA is processed every 2 weeks.

@codeDing18
Copy link
Copy Markdown
Contributor Author

@codeDing18 Note that CLA is processed every 2 weeks.

If the email is processed, will I receive a message notification?

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Apr 1, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@codeDing18
Copy link
Copy Markdown
Contributor Author

@cla-bot check

@cla-bot cla-bot Bot added the cla-signed label Apr 9, 2025
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Apr 9, 2025

The cla-bot has been summoned, and re-checked this pull request!

@codeDing18
Copy link
Copy Markdown
Contributor Author

@ebyhr hi, the cla is checked.Please help review.Thank you.

Comment thread docs/src/main/sphinx/connector/clickhouse.md Outdated
@codeDing18 codeDing18 force-pushed the mas branch 2 times, most recently from 49dfda4 to 9d6a5c0 Compare April 9, 2025 10:43
@codeDing18 codeDing18 requested a review from ebyhr April 10, 2025 01:30
@codeDing18
Copy link
Copy Markdown
Contributor Author

@ebyhr Is there anything else I need to update? If you have time,please take a look.Thank you!

Comment thread docs/src/main/sphinx/connector/clickhouse.md Outdated
Comment thread docs/src/main/sphinx/connector/clickhouse.md Outdated
@codeDing18
Copy link
Copy Markdown
Contributor Author

@ebyhr All updated.Please take a look.Thanks

@ebyhr ebyhr merged commit c09a8a8 into trinodb:master Apr 18, 2025
19 checks passed
@github-actions github-actions Bot added this to the 475 milestone Apr 18, 2025
@codeDing18 codeDing18 deleted the mas branch April 21, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

Add support for Bool type for ClickHouse connector

2 participants