Support column properties with jdbc connector

[hqbhoho]

Description

Add column properties for base jdbc connector to support auto_increment, default value and other column attribute.
When running SHOW CREATE TABLE include column properties present for these column attribute.

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Mysql
*  Add support for creating tables with `auto_increment` column property.

[github-actions]

This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack.

[hqbhoho]

The JdbcColumnHandle may include all the information returned by DatabaseMetaData.getColumns()?
If we do not add additional fields to the JdbcColumnHandle, due to serialization constraints, it seems that we can only implement a JdbcExtraColumnHandle in the base-jdbc package and configure JsonTypeInfo like this:

@JsonTypeInfo(
        use = JsonTypeInfo.Id.NAME,
        property = "@type")
@JsonSubTypes({
        @JsonSubTypes.Type(value = JdbcExtraColumnHandle.class, name = "system:io.trino.plugin.jdbc.JdbcExtraColumnHandle"),
        @JsonSubTypes.Type(value = JdbcColumnHandle.class, name = "system:io.trino.plugin.jdbc.JdbcColumnHandle")
})
public class JdbcColumnHandle
        implements ColumnHandle
{
}

public class JdbcExtraColumnHandle
        extends JdbcColumnHandle
{
    private final boolean autoIncrement;
    ...
}     

@chenjian2664 @ebyhr So which way is better?

[ebyhr]

Please update MySQL connector's documentation.

[ebyhr]

Replace order of IntegerType and BigintType. We usually order as smaller → larger.
Also, I think this limitation is wrong. We can enable auto increment on tinyint and smallint types.

[hqbhoho]

Replace order of IntegerType and BigintType. We usually order as smaller → larger. Also, I think this limitation is wrong. We can enable auto increment on tinyint and smallint types.

Using AUTO_INCREMENT with float and double columns is deprecated as of MySQL 8.0.17 and support for it to be removed in a future version of MySQL. So we should only support integer types. I initially thought that the value ranges of ​TINYINT and ​SMALLINT were limited, so I assumed these two data types were not supported at first. I have added them.

[chenjian2664]

is it possible to add this into DefaultJdbcMetadata directly?

[chenjian2664]

Why not add the auto increment info here, so we can use it in DefaultJdbcMetadata directly

[hqbhoho]

Maybe different datasource will use different column properties, so different datasource will have their own getColumnMetadata from JdbcColumnHandle. If we are sure on how each datasource behave，we can unify them in JdbcColumnHandle#getColumnMetadata.

[chenjian2664]

Feel like maybe we could make this filed to Optional<Boolean>, use empty to mark the column not support such property.

[hqbhoho]

autoIncrement only mark column can auto generate or not, it would be like nullable. It can use datasource Metadata to control support such property or not.

[Copilot]

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

[hqbhoho]

@ebyhr PTAL and let me know if there's anything else to adjust.

[ebyhr]

Why did you move the section? Please separate a commit for moving.

[hqbhoho]

Table properties or column properties are part of the table management. So I move it into Schema and table management section

[ebyhr]

The requireNonNull isn't required in case of ImmutableSet.copyOf.

[hqbhoho]

done

[ebyhr]

"Unsupported column type for AUTO_INCREMENT: " + type

[hqbhoho]

done

[ebyhr]

getColumnMetadata -> toColumnMetadata

[ebyhr]

This may overwrite the existing extra info. Please verify handle.getColumnMetadata().getExtraInfo() is empty.

[hqbhoho]

done

[ebyhr]

Do we have the test coverage about a table having primary_key in a different order?

CREATE TABLE test(a bigint NOT NULL, b bigint NOT NULL WITH (auto_increment = true), c bigint) WITH (primary_key = ARRAY['b', 'a']);

[hqbhoho]

done

[ebyhr]

Rename this variable to expected.

[hqbhoho]

done

[hqbhoho]

@ebyhr PTAL and let me know if there's anything else to adjust. Thanks

[github-actions]

This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack.

[hqbhoho]

@ebyhr @chenjian2664 @Praveen2112 Could you PTAL at this PR ? Thanks

[github-actions]

This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack.

[github-actions]

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.